Skip to content

glow-dark theme#1883

Merged
lissy93 merged 2 commits into
lissy93:masterfrom
domportera:patch-2
Jul 26, 2025
Merged

glow-dark theme#1883
lissy93 merged 2 commits into
lissy93:masterfrom
domportera:patch-2

Conversation

@domportera
Copy link
Copy Markdown
Contributor

@domportera domportera commented Jul 23, 2025

domportera Medium domportera /patch-2 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 98 Label Unchecked Tasks Powered by Pull Request Badge

Category: Other (theme)

Overview
Added a dark variant of the Glow theme - I liked the glow theme the most, but was disappointed that there wasn't a dark variant and thought it deserved one. Now there is and I thought I might share the wealth :)

The base color is fairly indigo rather than just grey due to personal preference. I also don't have a great monitor, so tweaks are welcome as my view of it is biased by my hardware (it looks good here I swear)

Screenshot
preview

Code Quality Checklist (Please complete)
I'm not a web developer and so I haven't done any proper build checks - I literally just pasted my theme into github. Please forgive my novice-ness 😅But the general linting-related stuff should be consistent with what's present in the glow theme.

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@domportera domportera requested a review from lissy93 as a code owner July 23, 2025 14:01
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 23, 2025

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 459450a
🔍 Latest deploy log https://app.netlify.com/projects/dashy-dev/deploys/68826d34f3897d000881d162
😎 Deploy Preview https://deploy-preview-1883--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Owner

@lissy93 lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
If you want it to also show up in the theme selector dropdown, you'll need to add glow-dark here

https://github.com/Lissy93/dashy/blob/ef741e319b058e1631085e596947e0ba589bef53/src/utils/defaults.js#L90-L93

@domportera
Copy link
Copy Markdown
Contributor Author

Nice If you want it to also show up in the theme selector dropdown, you'll need to add glow-dark here

https://github.com/Lissy93/dashy/blob/ef741e319b058e1631085e596947e0ba589bef53/src/utils/defaults.js#L90-L93

my bad! i remembered & tried to do it on my phone, cried about the mobile github experience, and then forgot again 😅 i did it now though, thanks!

@lissy93 lissy93 merged commit 5387ec4 into lissy93:master Jul 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants