Ref/auth cleanup#2055
Merged
Merged
Conversation
Previously, if both env vars and appConfig.auth were configured, the values in conf.yml would take priority. This has now been reversed, since environmental values are more secure. Now BASIC_AUTH_USERNAME, BASIC_AUTH_PASSWORD will take precidence. Also, added a warning which will show if user attempts to use both methods (since they will conflict), advising them to delete one. When basic auth is enabled, all internal endpoints require HTTP basic auth headers to be sent. Once the user has authenticaed via the UI, these will be attached automatically. If ENABLE_HTTP_AUTH env var is unset, then the auth config is basically just a login page rather than an access control system.
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Refactor, docs and small functionality change
Overview
Issue Number
N/A