Fix request parsing (fixes #60) #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a191be to
723b6ff
Compare
Owner
|
@saks this is great, thanks! Released as 0.15.1 |
Contributor
Author
|
thank you @lipanski! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating issue #60, I found that at times not the entire request body is read after one
stream.readcall. I noticed that from time to time code was reading only 123 bytes out of 125. Remaining 2 bytes were making request body JSON impossible to parse which has resulted into the error that I've reported in comments for #60.I also noticed that current implementation does not allow reading requests that are longer than 1024 bytes. I've tried to address it.
Another issue that I found is that even parser status is
httparse::Status::Complete, it does not mean that entire body was read already. It should be fixed in proposed PR as well.It is tricky to automate testing of scenario when not entire request is read in one take, since it's random. Instead I've added a test that ensures that we can parse request that is longer than 1024 bytes.