Skip to content

Conversation

@kornelski
Copy link
Contributor

@kornelski kornelski commented Jan 12, 2021

mockito$ cargo upgrades
All dependencies are up to date!

@lipanski
Copy link
Owner

@kornelski thanks for the PR! seems like the 1.36 toolchain build is failing on the env_logger upgrade - see Travis. #[non_exhaustive] was stabilized in 1.40 as far as I see.

at this point I wouldn't have anything against increasing the min. supported toolchain to 1.40, which implies:

  • Changing all occurences of 1.36 in the README.md and travis.yml
  • Re-running clippy for the new min. supported toolchain: rustup run --install 1.40.0 cargo clippy --lib --tests --all-features -- -D clippy::pedantic -D clippy::nursery

alternatively you could also find an env_logger version that works with 1.36.

@kornelski
Copy link
Contributor Author

It's failing on pedantic clippy lints, which are turned into errors. I don't think it's a good idea to treat every pedantic suggestion (many of which are meaningless or wrong) as stop-the-build catastrophic error.

@lipanski
Copy link
Owner

It's failing on pedantic clippy lints, which are turned into errors. I don't think it's a good idea to treat every pedantic suggestion (many of which are meaningless or wrong) as stop-the-build catastrophic error.

feel free to disable the pedantic check in Travis (also in the README please), I know it can be a pain.

@kornelski kornelski force-pushed the deps branch 4 times, most recently from 9305efa to 42a74f6 Compare January 14, 2021 14:52
@kornelski
Copy link
Contributor Author

Ok, I've managed to make it a proper Travis Job.

@lipanski lipanski merged commit 92b7bb4 into lipanski:master Jan 24, 2021
@lipanski
Copy link
Owner

@kornelski thanks! the Travis jobs look lovely, though I trimmed some things down in #136

released with 0.29.0 🚀

@kornelski kornelski deleted the deps branch January 24, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants