Do not ignore DatabaseException for Snowflake #4034
Conversation
StevenMassaro
left a comment
There was a problem hiding this comment.
Please add an integration test for this.
…ion' into fix_snowflake_ignoring_db_exception
| @Test | ||
| public void testInvalidSqlThrowsException() throws Exception { |
There was a problem hiding this comment.
I am not familiar with this class. Does this run against snowflake?
There was a problem hiding this comment.
It runs to all configured databases on liquibase, but snowflake is not one of them. To test snowflake it needs to be on harness or liquibase-pro-tests.
There was a problem hiding this comment.
If I'm understanding correctly, since this fix is specific to Snowflake, this test does not cover it. Can you either add a test that does cover this fix or log a tech debt ticket to add integration tests for Snowflake (and also a test for this)?
There was a problem hiding this comment.
Nice. So I'll keep those tests (as they work for the other local databases) , but will log a debt to handle Snowflake .
XDelphiGrl
left a comment
There was a problem hiding this comment.
Liquibase was "eating" a Snowflake database error thrown by improper specification to create a column remark on a view. This fix re-throws the exception.
- Functional and test harness executions passing.
- No additional testing required.
APPROVED
* Rethrows the exception. * Adding integration test.
Impact
Description
Since Liquibase 4.19.1 , any SQL error raised on Snowflake is being silently ignored . This PR fixes the issue.
Requires https://github.com/liquibase/liquibase-pro-tests/pull/734 to be merged together.
Fixes #3984