fixes #5724: compare normalized file paths #5727
Conversation
|
@jgarec thanks for the detailed issue and PR . I ran some tests and it failed on Windows, so I pushed some extra replaces to your fix and now it seems fine. @Alf-Melmac this PR also fixes #5681 . I copied your new test from #5682 to this branch and it works as now we remove the If both of you could give this PR another round of test I would be grateful. |
|
@filipelautert Thanks! The removal of Paths.get looks promising. I'll check against the production setup tomorrow. |
|
@filipelautert, Still ok for me with your fix 👍 |
|
Can confirm that it also works in the actual project 👍 |
tati-qalified
left a comment
There was a problem hiding this comment.
I've tested multiple path types with different liquibase versions (4.9.1, 4.16.1, 4.24.0), to see if this build would recognise the path formats.
As far as I can tell, it works as expected.
Here are some of the recognised syntaxes:
changelog.xmlor./changelog.xml../changelog.xmlfolder1/subfolder/../changelog.xmlor./folder1/subfolder/../changelog.xmlclasspath:/folder1/changelog.xmlclasspath:/folder1/subfolder/../changelog.xml- same but setting a searchpath instead of using
classpath:
If there are any other formats I should test, let me know.
Impact
Description
fixes #5724
fixes #5681
To handle previous changeset deployed with 4.6.0 <= liquibase < 4.23.1; where filename contains relatives paths , this PR now compares filenames of incoming changeset and already executed changeset in the same way.
Things to be aware of
Things to worry about
Check current PR #5681 which impact the same code.
Additional Context