-
Notifications
You must be signed in to change notification settings - Fork 1.9k
DAT-17770 Package BQ commercial jar inside liquibase tar ball & zip #5982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… currently not needed and can be re-enabled later if required. 🔧 (create-release.yml): Update workflow to checkout liquibase-bigquery repository and re-version BigQuery extensions for build and installation. 📝: Comment out unused code related to saving keys and rebuilding installers 🔧: Comment out attaching files to draft release and signing files to prevent unnecessary actions in the workflow
… Maven and deploy to GitHub Packages. Introduce support for setting liquibase version dynamically. 🔧 (create-release.yml): Include build-bigquery-jars workflow in the release creation process to automate building and deploying BigQuery extensions.
…for liquibase version to trigger manual workflow run with specified version 🔧 (build-bigquery-jars.yml): Update distribution management URLs for liquibase-bigquery and liquibase-commercial-bigquery to point to GitHub Packages for deployment
…es during the build process 🚀 (build-bigquery-jars.yml): Update distributionManagement settings in pom.xml files to deploy BigQuery extensions to GitHub Packages
…e-bigquery and liquibase-commercial-bigquery dependencies 🚀 (build-bigquery-jars.yml): Deploy BigQuery extensions to GitHub Packages using updated URLs and credentials
…organize workflow steps for deploying BigQuery extensions to GitHub Packages
…sion from environment variable for the workflow 🔧 (build-bigquery-jars.yml): add temporal distributionManagement to pom.xml for GitHub Maven Packages deployment
…needed for the workflow 🔧 (build-bigquery-jars.yml): Update Maven commands to build and package BigQuery extensions 🔧 (build-bigquery-jars.yml): Remove unnecessary steps related to setting up distributionManagement in pom.xml 🔧 (build-bigquery-jars.yml): Update deploy commands to correctly deploy BigQuery extensions to GitHub Packages
…BigQuery extensions" for clarity and accuracy 🔧 (build-bigquery-jars.yml): Update job name to "Build & Deploy" for consistency with workflow name 🔧 (build-bigquery-jars.yml): Add deployment configuration for liquibase-bigquery and liquibase-bigquery-commercial packages 🔧 (build-bigquery-jars.yml): Update deployment steps to include environment variables for Maven credentials and tokens for secure deployment
…rror in the workflow configuration file
…xtra dot before .jar to ensure successful deployment of Liquibase BigQuery jars.
…fferent repositories to build and deploy BigQuery extensions efficiently
…e-commercial-bigquery package to match the correct naming convention
…uild job in the GitHub Actions workflow file
…' for clarity and consistency 🔧 (build-bigquery-jars.yml): remove unnecessary configuration for liquibase-bigquery and liquibase-commercial-bigquery repositories 🔧 (build-bigquery-jars.yml): update repositoryId to 'liquibase' for consistency in the deploy command configuration
…LIQUIBOT_PAT_GPM_ACCESS for improved clarity and security.
…AT_GPM_ACCESS for improved clarity and consistency in the workflow configuration. Remove unnecessary environment variables for MAVEN_USERNAME and MAVEN_PASSWORD.
…g GitHub Actions for future reference 🔧 (create-release.yml): Uncomment and configure build-azure-uber-jar job to build Azure Uber JAR with Liquibase version from setup job outputs. ✨ (create-release.yml): Update workflow to re-version artifacts for liquibase-pro, liquibase-azure-deps, liquibase-bigquery, and liquibase-commercial-bigquery to match the setup version. Add steps to download and sign artifacts, move files to final directory, cache completed artifacts, and set repository tags.
…ment step to prevent workflow failure if deployment fails
…not needed for now and upload artifacts instead
…re-artifacts to prevent unnecessary artifact download 🔧 (create-release.yml): Update action to download artifacts for bigquery using dawidd6/action-download-artifact@v5 for consistency 🔧 (create-release.yml): Comment out moving of liquibase-pro/liquibase-azure-deps files to prevent unnecessary file manipulation
…ase/action-download-artifact for downloading Liquibase artifacts.
…odules 🔧 (create-release.yml): Simplify artifact retrieval process by directly getting bigquery artifacts from the local maven repository
… currently not needed 🔧 (create-release.yml): Update reversion job to remove dependency on build-azure-uber-jar job and only depend on build-bigquery-jars job 🔧 (create-release.yml): Add error handling for downloading bigquery artifacts to prevent build failures
…aven username, and Maven password to enable downloading bigquery artifacts during workflow execution
…step to prevent unnecessary artifact download 🔧 (create-release.yml): add maven settings for liquibase and liquibase-pro repositories to enable snapshot updates and configure access credentials
…low to ensure consistency and compatibility with Maven dependencies 🔧 (create-release.yml): update download liquibase-artifacts step to maintain consistency and improve readability in the workflow configuration
…step as it is no longer needed in the workflow and can be skipped.
…he use of BigQuery in Liquibase for better clarity and consistency.
…quibase-commercial-bigquery packages to allow for versioned releases and snapshots for continuous integration and deployment.
…or signing artifacts to improve security and automation in the build process.
…TENSIONS to specify dependencies and extensions for release to GPM 🔧 (create-release.yml): Update workflow to build and download extension artifacts dynamically based on configuration variables. Remove commented out code and improve script readability. 🔧 Move files to a specific directory and update file paths for re-versioning process 🚀 Cache completed artifacts and set repository tags for version control 🚀 Build installers on macOS for apple notarization and restore completed artifacts 🔧 Set up JDK for GPG and re-version installers with necessary keys and passwords 🔧 Rebuild installers and sign files for distribution 🔧 Attach files to draft release for Liquibase versioning with GitHub actions
…the workflow file to ensure correct release of Liquibase extensions and artifacts. Remove unused code related to caching and setting repository tags.
…improve workflow readability 🔧 (create-release.yml): Comment out unnecessary move commands to declutter the workflow and improve maintainability
…n for GitHub Maven Package Registry 🔧 (generate_servers.sh): Add script to generate servers.json for GitHub Maven Package Registry 🔧 (create-release.yml): Update workflow to use generated repositories and servers files for GitHub Maven Package Registry configuration and dependencies/extensions management.
… scripts for generating repositories and servers JSON files 🔧 (create-release.yml): Refactor workflow to generate repositories and servers JSON dynamically based on extensions and secrets, improving maintainability and reducing manual configuration
…tension-jars jobs as they are not needed currently 🔧 (create-release.yml): Remove unnecessary code related to repositories and servers variables 🔧 (create-release.yml): Refactor file moving logic to handle multiple extension jars dynamically
…on jars in the release workflow to improve artifact generation and versioning process. Fix file paths for downloading and moving artifacts to ensure correct versioning and packaging. 🔧 (create-release.yml): Uncomment and update cache and set repository tags steps for GitHub release creation and versioning 🔧 (create-release.yml): Uncomment and update build-installers and re-version installers steps for GitHub release attachment and signing files for Liquibase deployment.
…liquibase extensions and improve clarity on the workflow for building extension jars
…ectly move the Liquibase extension JAR files to the output directory
filipelautert
requested changes
Jun 10, 2024
…variable and setup-maven action as they are not being used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Things to be aware of
Things to worry about
Additional Context