Skip to content

Conversation

@filipelautert
Copy link
Collaborator

No description provided.

@filipelautert
Copy link
Collaborator Author

@rberezen we need to test installers generation.

@rberezen rberezen requested a review from tati-qalified August 5, 2024 14:22
@rberezen
Copy link
Contributor

rberezen commented Aug 5, 2024

@rberezen we need to test installers generation.

@tati-qalified what os can you check?

@tati-qalified
Copy link
Contributor

@rberezen Windows and maybe Ubuntu

@rberezen
Copy link
Contributor

rberezen commented Aug 5, 2024

@rberezen Windows and maybe Ubuntu

could you please check Windows, I'll check the rest
https://github.com/liquibase/liquibase/actions/runs/10251637098 - installers should be availabe here when job is finished

@rberezen
Copy link
Contributor

rberezen commented Aug 5, 2024

@rberezen Windows and maybe Ubuntu

could you please check Windows, I'll check the rest https://github.com/liquibase/liquibase/actions/runs/10251637098 - installers should be availabe here when job is finished

okay, we need to have liquibase-pro branch with the same name to build installers
I'll create one and trigger build again

@rberezen
Copy link
Contributor

rberezen commented Aug 6, 2024

@tati-qalified @filipelautert https://github.com/liquibase/liquibase/actions/runs/10255902343 successful job, there is archive with intallers

@tati-qalified
Copy link
Contributor

@rberezen something strange happens - I had v4.25.0 in my path environment variable, and when I ran the installer with the option to update my existing version, it for some reason updated v4.23.0, which I didn't have linked anywhere.
It didn't change the value in the path, it just added a new variable with the new path.
Any ideas on why this could be happening?

@rberezen
Copy link
Contributor

rberezen commented Aug 6, 2024

@tati-qalified honestly, have no idea, try to reproduce again but make some clean up on your environment (remove old versions, env variables, etc)

@tati-qalified
Copy link
Contributor

@rberezen here are the installer options:
image

When I use "update the existing installation" and tick the "add liquibase to path" box, it doesn't check if it's already in the path. It will add it again instead of modifying the old one:
image

As the previous version is higher up on the list, that's the one that will be considered by the PC.
I think this beats the purpose of updating the existing installation

@rberezen
Copy link
Contributor

rberezen commented Aug 6, 2024

@rberezen here are the installer options: image

When I use "update the existing installation" and tick the "add liquibase to path" box, it doesn't check if it's already in the path. It will add it again instead of modifying the old one: image

As the previous version is higher up on the list, that's the one that will be considered by the PC. I think this beats the purpose of updating the existing installation

agree, but I think this is not introduced in this PR and should be fixed as a separate issue
cc @filipelautert

@filipelautert filipelautert added this to the 1NEXT milestone Aug 7, 2024
@filipelautert filipelautert marked this pull request as ready for review August 7, 2024 20:00
@filipelautert filipelautert merged commit 8ef23d5 into master Aug 7, 2024
@filipelautert filipelautert deleted the update-installer-jvm branch August 7, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants