-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore: upgrade installer jdk version to 21.0.4+7 #6119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rberezen we need to test installers generation. |
@tati-qalified what os can you check? |
|
@rberezen Windows and maybe Ubuntu |
could you please check Windows, I'll check the rest |
okay, we need to have liquibase-pro branch with the same name to build installers |
|
@tati-qalified @filipelautert https://github.com/liquibase/liquibase/actions/runs/10255902343 successful job, there is archive with intallers |
|
@rberezen something strange happens - I had v4.25.0 in my path environment variable, and when I ran the installer with the option to update my existing version, it for some reason updated v4.23.0, which I didn't have linked anywhere. |
|
@tati-qalified honestly, have no idea, try to reproduce again but make some clean up on your environment (remove old versions, env variables, etc) |
|
@rberezen here are the installer options: When I use "update the existing installation" and tick the "add liquibase to path" box, it doesn't check if it's already in the path. It will add it again instead of modifying the old one: As the previous version is higher up on the list, that's the one that will be considered by the PC. |
agree, but I think this is not introduced in this PR and should be fixed as a separate issue |
No description provided.