Skip to content

Fail validation for blank changeset ids (DAT-18773) #6472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
filipelautert merged 5 commits into from
Nov 12, 2024
Merged

Fail validation for blank changeset ids (DAT-18773) #6472

filipelautert merged 5 commits into from
Nov 12, 2024

Conversation

@abrackx
Copy link
Contributor

@abrackx abrackx commented Oct 30, 2024 •
edited
Loading

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

If a changeset id is entirely blank (one or more spaces) fail validation.

Things to be aware of

Do not fail validation for changes that have already been ran. Changes that have been ran with an empty changeset id that are marked as runOnChange or runAlways WILL fail validation.

Things to worry about

Additional Context

@abrackx abrackx self-assigned this Oct 30, 2024
StevenMassaro
StevenMassaro previously approved these changes Oct 30, 2024
View reviewed changes
@StevenMassaro StevenMassaro dismissed their stale review October 30, 2024 19:10

filipe's comments need to be addressed

@abrackx
[DAT-18773] Add shouldValidate check to conditional for checking auth…
3ec0e93 
…or and id. Do not validate ran changesets or changesets that will not be executed.
@filipelautert filipelautert merged commit 7d7f212 into master Nov 12, 2024
35 checks passed
@filipelautert filipelautert deleted the DAT-18773 branch November 12, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MalloD12 MalloD12 MalloD12 approved these changes

@filipelautert filipelautert filipelautert approved these changes

@wwillard7800 wwillard7800 Awaiting requested review from wwillard7800 wwillard7800 is a code owner

@StevenMassaro StevenMassaro Awaiting requested review from StevenMassaro

Assignees

@abrackx abrackx

Labels

TypeBug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abrackx @filipelautert @StevenMassaro @MalloD12 @murrayadam