The type of attributes "ordered" and "cycle" should be boolean #2725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change type of cycle and ordered attributes to booleanExp
change type of cycle and ordered attributes to booleanExp
…o DartVerder-patch-1
Don't force defaults in xsd
nvoxland
approved these changes
May 2, 2022
Contributor
nvoxland
left a comment
There was a problem hiding this comment.
Thanks for the fix!
I updated the PR to not change the 4.9.xsd. Changes only need to go into the -next.xsd and they will get included in the next xsd version.
I also took out the default="false" change, we don't include defaults in the XSD, so that extensions can override defaults in the code as needed.
Code review and test results:
Things to be aware of
- Only changes the XSD better limit what can be set in ordered/cycled to just true/false or expressions
- Only impacts people who use the next xsd file, not existing xsd files.
Things to worry about
- Nothing
Contributor
|
Added ReleaseMajor label because XSD changes must go into a major release. |
Contributor
XDelphiGrl
approved these changes
May 16, 2022
suryaaki2
approved these changes
May 16, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2724