Fixes behaviour of includeAll by keeping the trailing slash on the path #3506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th (Paths.get added on #3355 to normalize Strings removes it)
StevenMassaro
approved these changes
Nov 28, 2022
suryaaki2
approved these changes
Nov 28, 2022
abrackx
approved these changes
Nov 28, 2022
XDelphiGrl
approved these changes
Nov 28, 2022
Contributor
XDelphiGrl
left a comment
There was a problem hiding this comment.
PR addresses a regression introduced while fixing the path shown in some output messages and the value stored in DATABASECHANGELOG tracking table when include or includeAll changesets specify relativeToChangelog=true. The original fix was too broad, and stripped trailing as well as leading slashes; only leading should be removed. This fix restores the correct behavior of keeping trailing slashes.
- Automated functional and test harness executions passing.
- S3 extension test that exposed the bug is fixed by this PR.
- New unit test added.
- No additional testing required.
APPROVED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
PR #3355 aimed to fix issues related to "./" and "../" , but by using Paths.get it is also removing trailing slashs. The changed method has logic to append the trailing slash, but it is located above the new code - so it baceme useless. This PR moves the code that fixes the path to be executed after Paths.get.
Things to be aware of
Things to worry about
Additional Context