Add support for Lian Li GA II LCD AIO cooler#795
Conversation
|
Done some tests with custom fork of coolercontrold on Linux |
jonasmalacofilho
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR, and sorry for the late feedback. I've been swamped...
I left some comments, please take a look.
| if channel == "pump": | ||
| self._set_pump_lighting(mode, colors, speed, direction, **kwargs) | ||
| elif channel == "fan": | ||
| self._set_fan_lighting(mode, colors, speed, direction, **kwargs) |
There was a problem hiding this comment.
There's too much duplication between the two functions. As a result of fixing that, this should likely be refactored too.
There was a problem hiding this comment.
I did refactor color writing to a static function to reduce duplication. Apart from that I'd say these two functions should not be unified, as they have different mode and speed options and different byte structure as well.
|
Hi, thank you for reviewing the PR, I made changes accordingly. Let me know if there is anything else I can improve. |
Co-authored-by: Jonas Malaco <jonas@protocubo.io>
e50555c to
8bcfc97
Compare
|
Nothing of concern comes to mind, merging. Thanks! |
This pull request adds support for Lian Li GA II LCD, and possibly Lian Li GA II Trinity AIO coolers.
This device is controlled by host application (L-Connect on Windows) by USB HID communication. The driver was implemented by inspecting this communication with
USBPcap.Tested features on Linux:
Not tested:
Not implemented:
Checklist:
docs/*guide.mddevice guides, with ["new/changed in" notes]liquidctl.8Linux/Unix/Mac OS man pagedocs/developer/protocolNew CLI flag?
extra/completions/New device?
extra/linux/71-liquidctl.rules(instructions in the file header)gitMRLVNew driver?
docs/developer/protocol/