[FEAT] : temporary disable grayscale filter for set amount of time #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lirena00
approved these changes
Aug 12, 2025
Owner
There was a problem hiding this comment.
This does look good overall and the ui is also consistent with the overall app layout
but utils/storage.ts don't have any versioning in your implementation as discussed in
https://wxt.dev/storage#versioning and would result in some bugs when an old user would use this extension but I am also working on some other feature which do require some updates in storage so I guess I will add it myself, will merge it with new branch by EOD
thanks for the contribution!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
This PR adds the enhancement raised in the issue no 36
Proposed solution
Proofs of concept
Screencast.from.2025-08-12.03-01-48.webm
Screencast.from.2025-08-12.03-03-31.webm
NOTE-
I believe this pr covers all the necessary add-ons, edge cases required to push the feat into prod in the next update.
Both the poc's demonstrates all the claims made in the proposed solutions!