Build fixes #358
Merged
Build fixes #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why revert the commit 177b5a8 that is not a desirable fix. |
Member
|
Some commits in this merge request can be accepted though, for example the singleton and the icons ones. |
Contributor
Author
An auto-generated .cpp file wasn't compiling. Luckily this has been fixed by one of the new commits that renames the files again. Remaining 3 commits are now rebased. |
> Note: set_source_files_properties needs to be called before qt_add_qml_module -- https://doc.qt.io/qt-6/qml-singleton.html Also file path was wrong.
- Add back the liri.io prefix for embedded icon paths (it was dropped when deleting icons.qrc) - Produce the correct path in iconUrl() - Use Q_INIT_RESOURCE so that the linker doesn't trash the resources when building a static lib
plfiorini
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
It's closer to building than before at least.
test (or a benchmark) included?
Description of change
Fix various build issues I encountered while trying to update the library:
Unitssingleton not instantiated