Skip to content

[labs/gen-manifest] Emit attributes derived from reactive properties#5263

Merged
justinfagnani merged 1 commit into
mainfrom
analyzer-attributes
Mar 13, 2026
Merged

[labs/gen-manifest] Emit attributes derived from reactive properties#5263
justinfagnani merged 1 commit into
mainfrom
analyzer-attributes

Conversation

@justinfagnani

@justinfagnani justinfagnani commented Mar 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Addresses part of #2993

Adds attributes to custom element declarations, and attribute and reflects to custom element fields.

@justinfagnani justinfagnani requested a review from rictic March 13, 2026 20:21
@changeset-bot

changeset-bot Bot commented Mar 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 22da68d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/gen-manifest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Mar 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +7% (-1.09ms - +0.88ms)
    this-change vs tip-of-tree

render

  • this-change: 42.75ms - 43.73ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +7% (-0.27ms - +1.40ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-0.86ms - +0.47ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-3.59ms - +1.34ms)
    this-change vs tip-of-tree

update

  • this-change: 455.05ms - 460.20ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-1.97ms - +1.14ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.95ms - +2.42ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-10.97ms - +4.15ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 439.45ms - 444.61ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-6.37ms - +12.56ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
42.75ms - 43.73ms-

update

VersionAvg timevs
455.05ms - 460.20ms-

update-reflect

VersionAvg timevs
439.45ms - 444.61ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.51ms - 20.83ms-unsure 🔍
-1% - +7%
-0.27ms - +1.40ms		unsure 🔍
-5% - +6%
-0.90ms - +1.13ms
tip-of-tree
tip-of-tree		19.09ms - 20.12msunsure 🔍
-7% - +1%
-1.40ms - +0.27ms		-unsure 🔍
-7% - +2%
-1.38ms - +0.48ms
previous-release
previous-release		19.28ms - 20.83msunsure 🔍
-6% - +4%
-1.13ms - +0.90ms		unsure 🔍
-2% - +7%
-0.48ms - +1.38ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.63ms - 39.77ms-unsure 🔍
-5% - +3%
-1.97ms - +1.14ms		unsure 🔍
-4% - +6%
-1.39ms - +2.12ms
tip-of-tree
tip-of-tree		37.98ms - 40.24msunsure 🔍
-3% - +5%
-1.14ms - +1.97ms		-unsure 🔍
-3% - +7%
-1.01ms - +2.57ms
previous-release
previous-release		36.94ms - 39.72msunsure 🔍
-5% - +4%
-2.12ms - +1.39ms		unsure 🔍
-7% - +3%
-2.57ms - +1.01ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.45ms - 13.90ms-unsure 🔍
-8% - +7%
-1.09ms - +0.88ms		unsure 🔍
-8% - +7%
-1.01ms - +0.97ms
tip-of-tree
tip-of-tree		12.61ms - 13.95msunsure 🔍
-7% - +8%
-0.88ms - +1.09ms		-unsure 🔍
-7% - +8%
-0.87ms - +1.03ms
previous-release
previous-release		12.52ms - 13.87msunsure 🔍
-7% - +8%
-0.97ms - +1.01ms		unsure 🔍
-8% - +6%
-1.03ms - +0.87ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.74ms - 36.72ms-unsure 🔍
-2% - +1%
-0.86ms - +0.47ms		unsure 🔍
-2% - +1%
-0.90ms - +0.51ms
tip-of-tree
tip-of-tree		35.98ms - 36.87msunsure 🔍
-1% - +2%
-0.47ms - +0.86ms		-unsure 🔍
-2% - +2%
-0.68ms - +0.68ms
previous-release
previous-release		35.92ms - 36.93msunsure 🔍
-1% - +2%
-0.51ms - +0.90ms		unsure 🔍
-2% - +2%
-0.68ms - +0.68ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
73.43ms - 76.00ms-unsure 🔍
-1% - +3%
-0.95ms - +2.42ms		unsure 🔍
-0% - +4%
-0.34ms - +3.12ms
tip-of-tree
tip-of-tree		72.90ms - 75.06msunsure 🔍
-3% - +1%
-2.42ms - +0.95ms		-unsure 🔍
-1% - +3%
-0.92ms - +2.23ms
previous-release
previous-release		72.18ms - 74.47msunsure 🔍
-4% - +0%
-3.12ms - +0.34ms		unsure 🔍
-3% - +1%
-2.23ms - +0.92ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
104.84ms - 106.10ms-unsure 🔍
-3% - +1%
-3.59ms - +1.34ms		unsure 🔍
-2% - +1%
-2.15ms - +0.55ms
tip-of-tree
tip-of-tree		104.21ms - 108.98msunsure 🔍
-1% - +3%
-1.34ms - +3.59ms		-unsure 🔍
-2% - +3%
-2.34ms - +3.00ms
previous-release
previous-release		105.08ms - 107.46msunsure 🔍
-1% - +2%
-0.55ms - +2.15ms		unsure 🔍
-3% - +2%
-3.00ms - +2.34ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
452.68ms - 463.12ms-unsure 🔍
-2% - +1%
-10.97ms - +4.15ms		unsure 🔍
-1% - +2%
-5.08ms - +7.72ms
tip-of-tree
tip-of-tree		455.84ms - 466.78msunsure 🔍
-1% - +2%
-4.15ms - +10.97ms		-unsure 🔍
-0% - +2%
-1.88ms - +11.33ms
previous-release
previous-release		452.88ms - 460.28msunsure 🔍
-2% - +1%
-7.72ms - +5.08ms		unsure 🔍
-2% - +0%
-11.33ms - +1.88ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
477.23ms - 492.63ms-unsure 🔍
-1% - +3%
-6.37ms - +12.56ms		unsure 🔍
-1% - +3%
-5.60ms - +13.25ms
tip-of-tree
tip-of-tree		476.33ms - 487.34msunsure 🔍
-3% - +1%
-12.56ms - +6.37ms		-unsure 🔍
-1% - +2%
-7.01ms - +8.46ms
previous-release
previous-release		475.67ms - 486.54msunsure 🔍
-3% - +1%
-13.25ms - +5.60ms		unsure 🔍
-2% - +1%
-8.46ms - +7.01ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions

github-actions Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

The size of lit-html.js and lit-core.min.js are as expected.

@justinfagnani justinfagnani merged commit c5f4811 into main Mar 13, 2026
11 checks passed
@justinfagnani justinfagnani deleted the analyzer-attributes branch March 13, 2026 23:53
@justinfagnani justinfagnani mentioned this pull request Mar 13, 2026
Open
16 tasks
kyubisation pushed a commit to kyubisation/lit that referenced this pull request May 7, 2026
@justinfagnani @kyubisation
[labs/gen-manifest] Emit attributes derived from reactive properties (l…
6c2b45f 
…it#5263)
@lit-robot lit-robot mentioned this pull request May 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinfagnani @rictic