[lit-html] Don't allow classMap to override static classes #1764

justinfagnani · 2021-04-18T01:34:03Z

Fixes #1278

github-actions · 2021-04-18T01:34:22Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -3% - +1% (-1.23ms - +0.52ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -2% - +2% (-1.79ms - +1.95ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +4% (-0.69ms - +1.66ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +7% (-0.19ms - +0.89ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +3% (-1.10ms - +1.72ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +1% (-1.29ms - +0.80ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -2% - +1% (-15.48ms - +8.15ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -3% - +2% (-3.53ms - +2.53ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -0% - +3% (-1.09ms - +10.86ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-4.37ms - +0.87ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +1% (-27.75ms - +12.06ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -2% - +1% (-21.25ms - +6.20ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +2% (-21.24ms - +18.27ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 89.0.4389.114
Sample size: 50
Built by: Benchmarks #1311
Commit: fbdb524

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	97.74ms - 100.26ms	-	unsure 🔍 -2% - +2% -1.79ms - +1.95ms	faster ✔ 19% - 22% 24.15ms - 28.14ms
tip-of-tree tip-of-tree	97.54ms - 100.31ms	unsure 🔍 -2% - +2% -1.95ms - +1.79ms	-	faster ✔ 19% - 22% 24.15ms - 28.30ms
previous-release previous-release	123.60ms - 126.69ms	slower ❌ 24% - 29% 24.15ms - 28.14ms	slower ❌ 24% - 29% 24.15ms - 28.30ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	832.04ms - 848.27ms	-	unsure 🔍 -2% - +1% -15.48ms - +8.15ms	faster ✔ 7% - 10% 66.49ms - 91.51ms
tip-of-tree tip-of-tree	835.23ms - 852.40ms	unsure 🔍 -1% - +2% -8.15ms - +15.48ms	-	faster ✔ 7% - 10% 62.52ms - 88.15ms
previous-release previous-release	909.64ms - 928.67ms	slower ❌ 8% - 11% 66.49ms - 91.51ms	slower ❌ 7% - 11% 62.52ms - 88.15ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	897.67ms - 916.84ms	-	unsure 🔍 -2% - +1% -21.25ms - +6.20ms	faster ✔ 4% - 6% 35.51ms - 62.27ms
tip-of-tree tip-of-tree	904.96ms - 924.60ms	unsure 🔍 -1% - +2% -6.20ms - +21.25ms	-	faster ✔ 3% - 6% 27.81ms - 54.92ms
previous-release previous-release	946.81ms - 965.48ms	slower ❌ 4% - 7% 35.51ms - 62.27ms	slower ❌ 3% - 6% 27.81ms - 54.92ms	-

lit-html-kitchen-sink

Browser: chrome-headless 89.0.4389.114
Sample size: 30
Built by: Benchmarks #1311
Commit: fbdb524

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	41.34ms - 42.64ms	-	unsure 🔍 -2% - +4% -0.69ms - +1.66ms	faster ✔ 13% - 16% 6.14ms - 7.82ms
tip-of-tree tip-of-tree	40.53ms - 42.49ms	unsure 🔍 -4% - +2% -1.66ms - +0.69ms	-	faster ✔ 13% - 17% 6.35ms - 8.58ms
previous-release previous-release	48.44ms - 49.50ms	slower ❌ 14% - 19% 6.14ms - 7.82ms	slower ❌ 15% - 21% 6.35ms - 8.58ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	107.57ms - 111.02ms	-	unsure 🔍 -3% - +2% -3.53ms - +2.53ms	slower ❌ 1% - 7% 0.79ms - 7.27ms
tip-of-tree tip-of-tree	107.31ms - 112.29ms	unsure 🔍 -2% - +3% -2.53ms - +3.53ms	-	slower ❌ 1% - 8% 0.83ms - 8.23ms
previous-release previous-release	102.53ms - 108.01ms	faster ✔ 1% - 7% 0.79ms - 7.27ms	faster ✔ 1% - 7% 0.83ms - 8.23ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.42ms - 35.85ms	-	unsure 🔍 -3% - +1% -1.23ms - +0.52ms	unsure 🔍 -4% - +1% -1.36ms - +0.47ms
tip-of-tree tip-of-tree	34.99ms - 35.98ms	unsure 🔍 -1% - +4% -0.52ms - +1.23ms	-	unsure 🔍 -2% - +2% -0.85ms - +0.67ms
previous-release previous-release	35.01ms - 36.15ms	unsure 🔍 -1% - +4% -0.47ms - +1.36ms	unsure 🔍 -2% - +2% -0.67ms - +0.85ms	-

lit-html-repeat

Browser: chrome-headless 89.0.4389.114
Sample size: 30
Built by: Benchmarks #1311
Commit: fbdb524

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.44ms - 14.47ms	-	unsure 🔍 -1% - +7% -0.19ms - +0.89ms	faster ✔ 10% - 17% 1.66ms - 2.78ms
tip-of-tree tip-of-tree	13.43ms - 13.78ms	unsure 🔍 -6% - +1% -0.89ms - +0.19ms	-	faster ✔ 14% - 17% 2.28ms - 2.85ms
previous-release previous-release	15.95ms - 16.39ms	slower ❌ 11% - 20% 1.66ms - 2.78ms	slower ❌ 17% - 21% 2.28ms - 2.85ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	409.37ms - 418.53ms	-	unsure 🔍 -0% - +3% -1.09ms - +10.86ms	faster ✔ 27% - 29% 154.00ms - 170.56ms
tip-of-tree tip-of-tree	405.24ms - 412.90ms	unsure 🔍 -3% - +0% -10.86ms - +1.09ms	-	faster ✔ 28% - 30% 159.28ms - 175.05ms
previous-release previous-release	569.33ms - 583.13ms	slower ❌ 37% - 41% 154.00ms - 170.56ms	slower ❌ 39% - 43% 159.28ms - 175.05ms	-

lit-html-template-heavy

Browser: chrome-headless 89.0.4389.114
Sample size: 50
Built by: Benchmarks #1311
Commit: fbdb524

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	65.64ms - 67.82ms	-	unsure 🔍 -2% - +3% -1.10ms - +1.72ms	faster ✔ 19% - 23% 15.91ms - 19.34ms
tip-of-tree tip-of-tree	65.52ms - 67.31ms	unsure 🔍 -3% - +2% -1.72ms - +1.10ms	-	faster ✔ 20% - 23% 16.34ms - 19.53ms
previous-release previous-release	83.04ms - 85.67ms	slower ❌ 24% - 29% 15.91ms - 19.34ms	slower ❌ 24% - 30% 16.34ms - 19.53ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	134.98ms - 137.87ms	-	unsure 🔍 -3% - +1% -4.37ms - +0.87ms	faster ✔ 17% - 19% 27.70ms - 32.67ms
tip-of-tree tip-of-tree	136.00ms - 140.36ms	unsure 🔍 -1% - +3% -0.87ms - +4.37ms	-	faster ✔ 15% - 19% 25.46ms - 31.40ms
previous-release previous-release	164.59ms - 168.63ms	slower ❌ 20% - 24% 27.70ms - 32.67ms	slower ❌ 18% - 23% 25.46ms - 31.40ms	-

reactive-element-list

Browser: chrome-headless 89.0.4389.114
Sample size: 50
Built by: Benchmarks #1311
Commit: fbdb524

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	70.65ms - 72.07ms	-	unsure 🔍 -2% - +1% -1.29ms - +0.80ms	unsure 🔍 -2% - +1% -1.41ms - +0.95ms
tip-of-tree tip-of-tree	70.84ms - 72.38ms	unsure 🔍 -1% - +2% -0.80ms - +1.29ms	-	unsure 🔍 -2% - +2% -1.20ms - +1.24ms
previous-release previous-release	70.65ms - 72.53ms	unsure 🔍 -1% - +2% -0.95ms - +1.41ms	unsure 🔍 -2% - +2% -1.24ms - +1.20ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	880.98ms - 906.90ms	-	unsure 🔍 -3% - +1% -27.75ms - +12.06ms	unsure 🔍 -3% - +1% -23.87ms - +11.73ms
tip-of-tree tip-of-tree	886.68ms - 916.90ms	unsure 🔍 -1% - +3% -12.06ms - +27.75ms	-	unsure 🔍 -2% - +2% -17.64ms - +21.20ms
previous-release previous-release	887.81ms - 912.21ms	unsure 🔍 -1% - +3% -11.73ms - +23.87ms	unsure 🔍 -2% - +2% -21.20ms - +17.64ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	985.24ms - 1013.38ms	-	unsure 🔍 -2% - +2% -21.24ms - +18.27ms	unsure 🔍 -2% - +2% -22.46ms - +17.93ms
tip-of-tree tip-of-tree	986.92ms - 1014.66ms	unsure 🔍 -2% - +2% -18.27ms - +21.24ms	-	unsure 🔍 -2% - +2% -20.84ms - +19.28ms
previous-release previous-release	987.08ms - 1016.06ms	unsure 🔍 -2% - +2% -17.93ms - +22.46ms	unsure 🔍 -2% - +2% -19.28ms - +20.84ms	-

_{tachometer-reporter-action v2 for Benchmarks}

packages/lit-html/src/directives/class-map.ts

changeset-bot · 2021-08-27T17:33:45Z

🦋 Changeset detected

Latest commit: 63c67c4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2021-08-27T17:34:09Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: faster ✔ 1% - 8% (0.18ms - 3.78ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -1% - +3% (-1.00ms - +3.66ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -0% - +5% (-0.11ms - +2.69ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -10% - +2% (-1.81ms - +0.36ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-2.18ms - +0.92ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +1% (-2.25ms - +0.76ms)
^{this-change vs tip-of-tree}

update

lit-element-list: slower ❌ 0% - 3% (1.52ms - 28.61ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-2.08ms - +6.56ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -6% - +6% (-36.50ms - +37.07ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +2% (-2.68ms - +3.32ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-12.24ms - +9.60ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -2% - +1% (-17.98ms - +11.64ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-6.01ms - +16.11ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 92.0.4515.131
Sample size: 50
Built by: Benchmarks #1847
Commit: de5a2d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	127.67ms - 131.18ms	-	unsure 🔍 -1% - +3% -1.00ms - +3.66ms	faster ✔ 19% - 22% 31.42ms - 36.43ms
tip-of-tree tip-of-tree	126.57ms - 129.62ms	unsure 🔍 -3% - +1% -3.66ms - +1.00ms	-	faster ✔ 20% - 23% 32.90ms - 37.60ms
previous-release previous-release	161.56ms - 165.13ms	slower ❌ 24% - 28% 31.42ms - 36.43ms	slower ❌ 25% - 30% 32.90ms - 37.60ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1102.02ms - 1122.79ms	-	slower ❌ 0% - 3% 1.52ms - 28.61ms	faster ✔ 6% - 8% 70.73ms - 101.56ms
tip-of-tree tip-of-tree	1088.65ms - 1106.04ms	faster ✔ 0% - 3% 1.52ms - 28.61ms	-	faster ✔ 7% - 10% 86.87ms - 115.54ms
previous-release previous-release	1187.16ms - 1209.94ms	slower ❌ 6% - 9% 70.73ms - 101.56ms	slower ❌ 8% - 11% 86.87ms - 115.54ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1113.25ms - 1136.98ms	-	unsure 🔍 -2% - +1% -17.98ms - +11.64ms	faster ✔ 5% - 8% 57.75ms - 90.82ms
tip-of-tree tip-of-tree	1119.42ms - 1137.15ms	unsure 🔍 -1% - +2% -11.64ms - +17.98ms	-	faster ✔ 5% - 7% 56.58ms - 85.65ms
previous-release previous-release	1187.88ms - 1210.92ms	slower ❌ 5% - 8% 57.75ms - 90.82ms	slower ❌ 5% - 8% 56.58ms - 85.65ms	-

lit-html-kitchen-sink

Browser: chrome-headless 92.0.4515.131
Sample size: 30
Built by: Benchmarks #1847
Commit: de5a2d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	51.71ms - 53.49ms	-	unsure 🔍 -0% - +5% -0.11ms - +2.69ms	faster ✔ 14% - 18% 8.83ms - 11.50ms
tip-of-tree tip-of-tree	50.23ms - 52.39ms	unsure 🔍 -5% - +0% -2.69ms - +0.11ms	-	faster ✔ 16% - 20% 9.99ms - 12.92ms
previous-release previous-release	61.77ms - 63.76ms	slower ❌ 17% - 22% 8.83ms - 11.50ms	slower ❌ 19% - 26% 9.99ms - 12.92ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	134.76ms - 140.34ms	-	unsure 🔍 -2% - +5% -2.08ms - +6.56ms	faster ✔ 3% - 8% 3.73ms - 11.91ms
tip-of-tree tip-of-tree	132.02ms - 138.60ms	unsure 🔍 -5% - +1% -6.56ms - +2.08ms	-	faster ✔ 4% - 10% 5.61ms - 14.51ms
previous-release previous-release	142.38ms - 148.36ms	slower ❌ 3% - 9% 3.73ms - 11.91ms	slower ❌ 4% - 11% 5.61ms - 14.51ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	42.58ms - 44.07ms	-	faster ✔ 1% - 8% 0.18ms - 3.78ms	unsure 🔍 -5% - +2% -2.02ms - +1.09ms
tip-of-tree tip-of-tree	43.67ms - 46.95ms	slower ❌ 0% - 9% 0.18ms - 3.78ms	-	unsure 🔍 -1% - +8% -0.62ms - +3.65ms
previous-release previous-release	42.43ms - 45.15ms	unsure 🔍 -3% - +5% -1.09ms - +2.02ms	unsure 🔍 -8% - +1% -3.65ms - +0.62ms	-

lit-html-repeat

Browser: chrome-headless 92.0.4515.131
Sample size: 30
Built by: Benchmarks #1847
Commit: de5a2d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	17.10ms - 17.87ms	-	unsure 🔍 -10% - +2% -1.81ms - +0.36ms	faster ✔ 8% - 21% 1.47ms - 4.49ms
tip-of-tree tip-of-tree	17.19ms - 19.23ms	unsure 🔍 -2% - +10% -0.36ms - +1.81ms	-	faster ✔ 3% - 19% 0.48ms - 4.04ms
previous-release previous-release	19.00ms - 21.92ms	slower ❌ 8% - 26% 1.47ms - 4.49ms	slower ❌ 2% - 23% 0.48ms - 4.04ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	545.03ms - 601.27ms	-	unsure 🔍 -6% - +6% -36.50ms - +37.07ms	faster ✔ 25% - 35% 192.59ms - 297.73ms
tip-of-tree tip-of-tree	549.14ms - 596.58ms	unsure 🔍 -6% - +6% -37.07ms - +36.50ms	-	faster ✔ 25% - 35% 195.09ms - 295.80ms
previous-release previous-release	773.89ms - 862.73ms	slower ❌ 32% - 53% 192.59ms - 297.73ms	slower ❌ 33% - 53% 195.09ms - 295.80ms	-

lit-html-template-heavy

Browser: chrome-headless 92.0.4515.131
Sample size: 50
Built by: Benchmarks #1847
Commit: de5a2d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	82.54ms - 84.52ms	-	unsure 🔍 -3% - +1% -2.18ms - +0.92ms	faster ✔ 16% - 18% 15.51ms - 18.51ms
tip-of-tree tip-of-tree	82.97ms - 85.35ms	unsure 🔍 -1% - +3% -0.92ms - +2.18ms	-	faster ✔ 15% - 18% 14.74ms - 18.02ms
previous-release previous-release	99.41ms - 101.67ms	slower ❌ 18% - 22% 15.51ms - 18.51ms	slower ❌ 17% - 22% 14.74ms - 18.02ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	182.55ms - 186.99ms	-	unsure 🔍 -1% - +2% -2.68ms - +3.32ms	faster ✔ 10% - 13% 19.88ms - 26.23ms
tip-of-tree tip-of-tree	182.43ms - 186.47ms	unsure 🔍 -2% - +1% -3.32ms - +2.68ms	-	faster ✔ 10% - 13% 20.34ms - 26.41ms
previous-release previous-release	205.56ms - 210.09ms	slower ❌ 11% - 14% 19.88ms - 26.23ms	slower ❌ 11% - 14% 20.34ms - 26.41ms	-

reactive-element-list

Browser: chrome-headless 92.0.4515.131
Sample size: 50
Built by: Benchmarks #1847
Commit: de5a2d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	84.91ms - 86.93ms	-	unsure 🔍 -3% - +1% -2.25ms - +0.76ms	unsure 🔍 -2% - +2% -1.51ms - +1.32ms
tip-of-tree tip-of-tree	85.56ms - 87.79ms	unsure 🔍 -1% - +3% -0.76ms - +2.25ms	-	unsure 🔍 -1% - +2% -0.84ms - +2.14ms
previous-release previous-release	85.03ms - 87.01ms	unsure 🔍 -2% - +2% -1.32ms - +1.51ms	unsure 🔍 -2% - +1% -2.14ms - +0.84ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1118.42ms - 1131.88ms	-	unsure 🔍 -1% - +1% -12.24ms - +9.60ms	unsure 🔍 -1% - +0% -16.25ms - +4.92ms
tip-of-tree tip-of-tree	1117.87ms - 1135.07ms	unsure 🔍 -1% - +1% -9.60ms - +12.24ms	-	unsure 🔍 -1% - +1% -16.20ms - +7.52ms
previous-release previous-release	1122.64ms - 1138.98ms	unsure 🔍 -0% - +1% -4.92ms - +16.25ms	unsure 🔍 -1% - +1% -7.52ms - +16.20ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1191.93ms - 1209.63ms	-	unsure 🔍 -1% - +1% -6.01ms - +16.11ms	unsure 🔍 -1% - +1% -10.95ms - +13.41ms
tip-of-tree tip-of-tree	1189.10ms - 1202.36ms	unsure 🔍 -1% - +0% -16.11ms - +6.01ms	-	unsure 🔍 -1% - +1% -14.49ms - +6.87ms
previous-release previous-release	1191.17ms - 1207.92ms	unsure 🔍 -1% - +1% -13.41ms - +10.95ms	unsure 🔍 -1% - +1% -6.87ms - +14.49ms	-

_{tachometer-reporter-action v2 for Benchmarks}

packages/lit-html/src/directives/class-map.ts

[lit-html] Don't allow classMap to override static classes

37b5a74

google-cla bot added the cla: yes label Apr 18, 2021

justinfagnani requested a review from sorvell April 18, 2021 01:34

kevinpschaaf requested changes Apr 20, 2021

View reviewed changes

packages/lit-html/src/directives/class-map.ts Show resolved Hide resolved

justinfagnani added this to the Lit RC.next milestone May 25, 2021

Merge branch 'main' into class-map-statics

73a011d

justinfagnani added 2 commits August 27, 2021 10:35

Add changeset

73aec88

Fix ssr classMap unit test

ed19bd8

justinfagnani requested a review from kevinpschaaf August 27, 2021 18:42

sorvell approved these changes Aug 30, 2021

View reviewed changes

packages/lit-html/src/directives/class-map.ts Show resolved Hide resolved

packages/lit-html/src/directives/class-map.ts Show resolved Hide resolved

kevinpschaaf approved these changes Sep 1, 2021

View reviewed changes

justinfagnani added 2 commits September 1, 2021 14:19

Clean up tests

979af4d

Merge branch 'main' into class-map-statics

63c67c4

justinfagnani merged commit 0b4d6ed into main Sep 1, 2021

justinfagnani deleted the class-map-statics branch September 1, 2021 23:24

web-padawan mentioned this pull request Jan 3, 2023

feat: add OverlayClassMixin to forward CSS class names vaadin/web-components#5207

Merged

[lit-html] Don't allow classMap to override static classes #1764

[lit-html] Don't allow classMap to override static classes #1764

Uh oh!

Conversation

justinfagnani commented Apr 18, 2021

Uh oh!

github-actions bot commented Apr 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Uh oh!

changeset-bot bot commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 18, 2021 •

edited

Loading

changeset-bot bot commented Aug 27, 2021 •

edited

Loading

github-actions bot commented Aug 27, 2021 •

edited

Loading