Skip to content

Conversation

@thescientist13
Copy link
Contributor

Corrected an import statement in the @lit-labs/ssr README.md.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2021

🦋 Changeset detected

Latest commit: b91ea68

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Aug 22, 2021
@thescientist13
Copy link
Contributor Author

Just confirming, should I add a changeset for this PR?

@justinfagnani
Copy link
Collaborator

Sure. Run npm run changeset, choose @lit-labs/ssr, patch and add something like "fixed import in README"

@abdonrd
Copy link
Contributor

abdonrd commented Aug 22, 2021

Sure. Run npm run changeset, choose @lit-labs/ssr, patch and add something like "fixed import in README"

Documentation changes should be logged in the changelog? I thought not.

@justinfagnani
Copy link
Collaborator

It's part of the release that will be published to npm. Not a big deal either way.

@justinfagnani justinfagnani merged commit 88d8608 into lit:main Aug 26, 2021
@thescientist13 thescientist13 deleted the chore/ssr-docs-fix-import-typo branch January 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants