Skip to content

[all] Cleanup obsolete TODOs #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinpschaaf merged 2 commits into from
Aug 23, 2021
Merged

[all] Cleanup obsolete TODOs #2073

kevinpschaaf merged 2 commits into from
Aug 23, 2021

Conversation

@kevinpschaaf
Copy link
Member

@kevinpschaaf kevinpschaaf commented Aug 21, 2021

In preparation for Lit 2 GA release, this PR cleans up old TODOs after an IRL scrub of them.

The TODOs remove here were either things that are no longer applicable (i.e. bugs that were fixed), notes that should just be comments (notes to reader, but do not require follow-up action), or ideas we decided against doing/changing.

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: bd83791

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Aug 21, 2021
@kevinpschaaf kevinpschaaf changed the title [all] Cleanup old TODOs [all] Cleanup obsolete TODOs Aug 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -16% - +7% (-9.46ms - +4.42ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -1% - +2% (-1.28ms - +1.95ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -8% - +4% (-4.70ms - +2.28ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +4% (-0.24ms - +0.65ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +1% (-2.50ms - +0.75ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +2% (-0.62ms - +1.35ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -1% - +1% (-6.15ms - +7.19ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -8% - +10% (-14.10ms - +16.82ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +2% (-2.76ms - +7.88ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.31ms - +4.38ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +1% (-4.86ms - +11.84ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +1% (-5.60ms - +9.45ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-6.85ms - +6.06ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
125.92ms - 128.19ms-unsure 🔍
-1% - +2%
-1.28ms - +1.95ms		faster ✔
22% - 24%
36.73ms - 39.81ms
tip-of-tree
tip-of-tree		125.58ms - 127.87msunsure 🔍
-2% - +1%
-1.95ms - +1.28ms		-faster ✔
23% - 24%
37.06ms - 40.15ms
previous-release
previous-release		164.29ms - 166.37msslower ❌
29% - 32%
36.73ms - 39.81ms		slower ❌
29% - 32%
37.06ms - 40.15ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1101.26ms - 1110.08ms-unsure 🔍
-1% - +1%
-6.15ms - +7.19ms		faster ✔
6% - 8%
76.15ms - 91.26ms
tip-of-tree
tip-of-tree		1100.14ms - 1110.16msunsure 🔍
-1% - +1%
-7.19ms - +6.15ms		-faster ✔
6% - 8%
76.31ms - 92.14ms
previous-release
previous-release		1183.24ms - 1195.51msslower ❌
7% - 8%
76.15ms - 91.26ms		slower ❌
7% - 8%
76.31ms - 92.14ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1112.38ms - 1124.51ms-unsure 🔍
-1% - +1%
-5.60ms - +9.45ms		faster ✔
5% - 6%
57.15ms - 73.89ms
tip-of-tree
tip-of-tree		1112.06ms - 1120.97msunsure 🔍
-1% - +0%
-9.45ms - +5.60ms		-faster ✔
5% - 6%
60.15ms - 74.74ms
previous-release
previous-release		1178.19ms - 1189.74msslower ❌
5% - 7%
57.15ms - 73.89ms		slower ❌
5% - 7%
60.15ms - 74.74ms		-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
55.77ms - 60.28ms-unsure 🔍
-8% - +4%
-4.70ms - +2.28ms		faster ✔
20% - 30%
14.57ms - 24.22ms
tip-of-tree
tip-of-tree		56.58ms - 61.90msunsure 🔍
-4% - +8%
-2.28ms - +4.70ms		-faster ✔
18% - 29%
13.16ms - 23.20ms
previous-release
previous-release		73.16ms - 81.68msslower ❌
24% - 42%
14.57ms - 24.22ms		slower ❌
21% - 40%
13.16ms - 23.20ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
159.84ms - 182.86ms-unsure 🔍
-8% - +10%
-14.10ms - +16.82ms		unsure 🔍
-11% - +6%
-19.14ms - +11.12ms
tip-of-tree
tip-of-tree		159.67ms - 180.32msunsure 🔍
-10% - +8%
-16.82ms - +14.10ms		-unsure 🔍
-11% - +5%
-19.62ms - +8.89ms
previous-release
previous-release		165.53ms - 185.19msunsure 🔍
-7% - +11%
-11.12ms - +19.14ms		unsure 🔍
-5% - +12%
-8.89ms - +19.62ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
52.81ms - 61.39ms-unsure 🔍
-16% - +7%
-9.46ms - +4.42ms		slower ❌
0% - 22%
0.40ms - 11.16ms
tip-of-tree
tip-of-tree		54.16ms - 65.08msunsure 🔍
-8% - +17%
-4.42ms - +9.46ms		-slower ❌
3% - 29%
1.95ms - 14.65ms
previous-release
previous-release		48.07ms - 54.56msfaster ✔
1% - 19%
0.40ms - 11.16ms		faster ✔
4% - 24%
1.95ms - 14.65ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
15.22ms - 15.87ms-unsure 🔍
-2% - +4%
-0.24ms - +0.65ms		faster ✔
11% - 16%
1.90ms - 3.00ms
tip-of-tree
tip-of-tree		15.03ms - 15.66msunsure 🔍
-4% - +2%
-0.65ms - +0.24ms		-faster ✔
12% - 17%
2.11ms - 3.20ms
previous-release
previous-release		17.55ms - 18.44msslower ❌
12% - 19%
1.90ms - 3.00ms		slower ❌
14% - 21%
2.11ms - 3.20ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
472.55ms - 480.65ms-unsure 🔍
-1% - +2%
-2.76ms - +7.88ms		faster ✔
28% - 30%
188.56ms - 206.94ms
tip-of-tree
tip-of-tree		470.60ms - 477.49msunsure 🔍
-2% - +1%
-7.88ms - +2.76ms		-faster ✔
29% - 31%
191.37ms - 209.25ms
previous-release
previous-release		666.10ms - 682.60msslower ❌
39% - 44%
188.56ms - 206.94ms		slower ❌
40% - 44%
191.37ms - 209.25ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
84.19ms - 86.35ms-unsure 🔍
-3% - +1%
-2.50ms - +0.75ms		faster ✔
14% - 17%
13.90ms - 17.27ms
tip-of-tree
tip-of-tree		84.93ms - 87.36msunsure 🔍
-1% - +3%
-0.75ms - +2.50ms		-faster ✔
13% - 16%
12.94ms - 16.49ms
previous-release
previous-release		99.56ms - 102.15msslower ❌
16% - 20%
13.90ms - 17.27ms		slower ❌
15% - 19%
12.94ms - 16.49ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
186.87ms - 191.34ms-unsure 🔍
-1% - +2%
-1.31ms - +4.38ms		faster ✔
9% - 12%
19.03ms - 25.27ms
tip-of-tree
tip-of-tree		185.81ms - 189.33msunsure 🔍
-2% - +1%
-4.38ms - +1.31ms		-faster ✔
10% - 12%
20.89ms - 26.48ms
previous-release
previous-release		209.09ms - 213.43msslower ❌
10% - 13%
19.03ms - 25.27ms		slower ❌
11% - 14%
20.89ms - 26.48ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
86.32ms - 87.77ms-unsure 🔍
-1% - +2%
-0.62ms - +1.35ms		unsure 🔍
-1% - +1%
-0.50ms - +1.24ms
tip-of-tree
tip-of-tree		86.01ms - 87.34msunsure 🔍
-2% - +1%
-1.35ms - +0.62ms		-unsure 🔍
-1% - +1%
-0.82ms - +0.83ms
previous-release
previous-release		86.19ms - 87.16msunsure 🔍
-1% - +1%
-1.24ms - +0.50ms		unsure 🔍
-1% - +1%
-0.83ms - +0.82ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1102.46ms - 1115.57ms-unsure 🔍
-0% - +1%
-4.86ms - +11.84ms		unsure 🔍
-0% - +1%
-4.38ms - +11.66ms
tip-of-tree
tip-of-tree		1100.35ms - 1110.69msunsure 🔍
-1% - +0%
-11.84ms - +4.86ms		-unsure 🔍
-1% - +1%
-6.79ms - +7.08ms
previous-release
previous-release		1100.76ms - 1109.99msunsure 🔍
-1% - +0%
-11.66ms - +4.38ms		unsure 🔍
-1% - +1%
-7.08ms - +6.79ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1168.41ms - 1178.01ms-unsure 🔍
-1% - +1%
-6.85ms - +6.06ms		unsure 🔍
-0% - +1%
-4.29ms - +8.00ms
tip-of-tree
tip-of-tree		1169.29ms - 1177.92msunsure 🔍
-1% - +1%
-6.06ms - +6.85ms		-unsure 🔍
-0% - +1%
-3.53ms - +8.02ms
previous-release
previous-release		1167.52ms - 1175.20msunsure 🔍
-1% - +0%
-8.00ms - +4.29ms		unsure 🔍
-1% - +0%
-8.02ms - +3.53ms		-

tachometer-reporter-action v2 for Benchmarks

@kevinpschaaf kevinpschaaf added this to the Lit RC.next milestone Aug 21, 2021
@kevinpschaaf kevinpschaaf merged commit 0312f3e into main Aug 23, 2021
@kevinpschaaf kevinpschaaf deleted the remove-old-todos branch August 23, 2021 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorvell sorvell sorvell approved these changes

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

Lit RC.4

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinpschaaf @sorvell