do not open command menu with Ctrl+Shift+K #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for livecodes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Deploying livecodes with
|
| Latest commit: |
7cbb103
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6694d91.livecodes.pages.dev |
| Branch Preview URL: | https://fix-ctrl-shift-k.livecodes.pages.dev |
|
Contributor
|
Size Change: -12 B (0%) Total Size: 971 kB ℹ️ View Unchanged
|
WalkthroughA guard condition in the command menu hotkey handler is updated to check that the Shift key is not pressed, preventing Ctrl+Shift+K from opening the command menu while keeping Ctrl+K functional. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)src/livecodes/core.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
🔇 Additional comments (1)
Tip 📝 Customizable high-level summaries are now available!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
sharno
reviewed
Nov 16, 2025
| // do not open the menu if shortcut is Ctrl+Shift+K | ||
| // wait for 500ms to allow other shortcuts like Ctrl+K Ctrl+0 | ||
| if (!ctrl(e)) { | ||
| if (!ctrl(e) || e.shiftKey) { |
There was a problem hiding this comment.
Maybe you should add meta and alt keys as well for future usages?
Collaborator
Author
There was a problem hiding this comment.
Good idea. I will do that isA.
Thank you.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
do not open command menu with Ctrl+Shift+K
Related Tickets & Documents
#918
Thank you @sharno !
Summary by CodeRabbit