fix(deps): update module github.com/pion/rtp to v2 #2475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daede01 to
b3756e7
Compare
b3756e7 to
c6e91a4
Compare
5c7891e to
5aec924
Compare
26d5926 to
1723824
Compare
7fc3f5b to
69c1b8f
Compare
9aa04e8 to
e1cee55
Compare
79a9d6e to
656b51c
Compare
5610079 to
fd5103a
Compare
|
Hello @davidzhao The pion/ice@v3 update fixes a race condition we have observed lately in our test environments. Connection setup is either instant or in some cases it takes over one second. After some digging we narrowed it down to the following pion/ice race condition pion/webrtc#2578 Because of that race, host candidates are sometimes treated as peer-reflexive candidates (prflx). And here's where the observed delay comes from: prflx candidates are selected only after a specific timeout, which is by default setup to 1 second. The relevant pion/ice code can be followed from here After a cursory look over the open issues I could not determine if others are affected by this issue. |
fd5103a to
494de92
Compare
bbfbd8d to
1f4b4a6
Compare
018136a to
f97452c
Compare
c18fa89 to
754b3fd
Compare
754b3fd to
7c8b684
Compare
7c8b684 to
7721ae6
Compare
7721ae6 to
d709dfb
Compare
3ba5ca1 to
32cd575
Compare
32cd575 to
6457c78
Compare
Generated by renovateBot
6457c78 to
7d1c123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1.8.26->v2.0.0Release Notes
pion/rtp (github.com/pion/rtp)
v2.0.0Compare Source
Configuration
📅 Schedule: Branch creation - "before 6am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.