Skip to content

Conversation

@jagerber48
Copy link
Contributor

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

NOTE!!!! This PR targets main, not master. This PR will be released in version 4.x (likely 4.0.0).

This PR eliminates functions, methods, and their corresponding tests that were deprecated in version 3.2.3: https://github.com/lmfit/uncertainties/releases/tag/3.2.3.

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.65%. Comparing base (f8bfcfe) to head (61a1c71).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   86.65%   85.65%   -1.01%     
==========================================
  Files          18       18              
  Lines        1904     1806      -98     
==========================================
- Hits         1650     1547     -103     
- Misses        254      259       +5     
Flag Coverage Δ
macos-latest-3.10 94.23% <100.00%> (-1.35%) ⬇️
macos-latest-3.11 94.23% <100.00%> (-1.35%) ⬇️
macos-latest-3.12 94.23% <100.00%> (-1.35%) ⬇️
macos-latest-3.8 94.23% <100.00%> (-1.35%) ⬇️
macos-latest-3.9 94.23% <100.00%> (-1.35%) ⬇️
no-numpy 80.73% <100.00%> (-1.21%) ⬇️
ubuntu-latest-3.10 94.23% <100.00%> (-1.35%) ⬇️
ubuntu-latest-3.11 94.23% <100.00%> (-1.35%) ⬇️
ubuntu-latest-3.12 94.23% <100.00%> (-1.35%) ⬇️
ubuntu-latest-3.8 94.23% <100.00%> (-1.35%) ⬇️
ubuntu-latest-3.9 94.23% <100.00%> (-1.35%) ⬇️
windows-latest-3.10 94.23% <100.00%> (-1.35%) ⬇️
windows-latest-3.11 94.23% <100.00%> (-1.35%) ⬇️
windows-latest-3.12 94.23% <100.00%> (-1.35%) ⬇️
windows-latest-3.8 94.23% <100.00%> (-1.35%) ⬇️
windows-latest-3.9 94.23% <100.00%> (-1.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #309 will not alter performance

Comparing jagerber48:remove_deprecated_functions (61a1c71) with main (f8bfcfe)

Summary

✅ 5 untouched benchmarks

@jagerber48 jagerber48 merged commit c3d5bb3 into lmfit:main May 22, 2025
21 of 22 checks passed
@jagerber48 jagerber48 deleted the remove_deprecated_functions branch May 22, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant