Skip to content

[FIX] add ssl params #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sebastienbeau wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIX] add ssl params #175

sebastienbeau wants to merge 1 commit into from

Conversation

@sebastienbeau
Copy link
Contributor

@sebastienbeau sebastienbeau commented Mar 22, 2020

No description provided.

@sebastienbeau sebastienbeau force-pushed the add-ssl-params-for-smtp branch from 58ae08b to 860203a Compare March 23, 2020 06:39
did
did requested changes Mar 23, 2020
View reviewed changes
lib/locomotive/steam/middlewares/auth.rb Outdated
password: smtp_config['password'],
authentication: smtp_config['authentication'] || 'plain',
enable_starttls_auto: (smtp_config['enable_starttls_auto'] || "0").to_bool,
ssl: (smtp_config['ssl'] || "0").to_bool,
Copy link
Member

@did did Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single quotes :-)

@sebastienbeau sebastienbeau force-pushed the add-ssl-params-for-smtp branch from 860203a to 6747b3d Compare March 23, 2020 10:56
@sebastienbeau
Copy link
Contributor Author

sebastienbeau commented Mar 23, 2020

@did fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@did did did requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sebastienbeau @did