Skip to content

pin docker dependency to <7.0.0 #9864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2023
Merged

pin docker dependency to <7.0.0 #9864

merged 2 commits into from
Dec 13, 2023

Conversation

@dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Dec 13, 2023

Motivation

It doesn't seem to break anything here yet but it technically could lead to the same kind of issues for users of community.

Recently the docker PyPI package was updated to 7.0.0 which started breaking integration tests in -ext with the following kind of exception:

docker.errors.DockerException: invalid tag 'localhost.localstack.cloud:4514/r-a9dfa6f4:latest': invalid reference format` anymore.

Context

Change that was included in their 7.0.0 release: docker/docker-py#3191

Changes

  • pin docker dependency to <7.0.0 to avoid the breaking change for now until we know how to circumvent this

@dominikschubert dominikschubert self-assigned this Dec 13, 2023
@github-actions
Copy link

github-actions bot commented Dec 13, 2023

S3 Image Test Results (AMD64 / ARM64)

    2 files      2 suites   3m 7s ⏱️
381 tests 331 ✔️   50 💤 0 ❌
762 runs  662 ✔️ 100 💤 0 ❌

Results for commit aad1041.

@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Dec 13, 2023
dfangl
dfangl approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@dfangl
Copy link
Member

dfangl commented Dec 13, 2023

Already reported upstream: docker/docker-py#3195
Should be fixed by: docker/docker-py#3196

@dominikschubert
Copy link
Member Author

dominikschubert commented Dec 13, 2023 •
edited
Loading

Failure of test_kinesis_firehose_opensearch_s3_backup seems like a flake.
Edit: added it to our list of flakes to keep track of it

@github-actions
Copy link

github-actions bot commented Dec 13, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 11m 28s ⏱️
2 405 tests 2 177 ✔️ 228 💤 0 ❌
2 406 runs  2 177 ✔️ 229 💤 0 ❌

Results for commit aad1041.

@dominikschubert dominikschubert merged commit 1677965 into master Dec 13, 2023
@dominikschubert dominikschubert deleted the pin-docker-pre-v7 branch December 13, 2023 09:09
@consideRatio
Copy link

consideRatio commented Mar 25, 2024

Reported this as a bug in docker/docker-py#3240

@alexrashed
Copy link
Member

alexrashed commented Mar 25, 2024

Hi @consideRatio!
It seems like there might be a misunderstanding. The bug was already reported and fixed in docker-py (see the comment from @dfangl above). There just isn't a release containing the fix yet.
However, we are pinning the version of docker-py until the release is out so you shouldn't see this issue in LocalStack.

@alexrashed alexrashed mentioned this pull request Mar 25, 2024
Closed
@consideRatio
Copy link

consideRatio commented Mar 25, 2024

Oh, thank you for helping me get that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfangl dfangl dfangl approved these changes

@alexrashed alexrashed Awaiting requested review from alexrashed

@steffyP steffyP Awaiting requested review from steffyP

Assignees

@dominikschubert dominikschubert

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dominikschubert @dfangl @consideRatio @alexrashed