Added a unit test for cypher text padding check in client's symmetric_decrypt_verify() #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AiyionPrime
suggested changes
Sep 17, 2024
Contributor
AiyionPrime
left a comment
There was a problem hiding this comment.
@BogdanYarotsky Thanks for cleaning up :)
Any chance you could create a unittest from this commented out test code instead of dropping it and reference it in line 1213?
This reverts commit d853f0d.
Author
|
@AiyionPrime Thanks for checking out the PR :) I've brought back and uncommented the padding check. Also added a unit test to validate that it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.