Added error for non-existing locale#18
Open
augbog wants to merge 1 commit into
Open
Conversation
- Updated README
Collaborator
|
Thanks, @augbog! I'll review this and add some tests a bit later. This PR doesn't block anything on your side, does it? |
Author
|
@iafan Nope doesn't block anything -- just wanted to contribute since I thought it was a useful error :) Great library! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps address issue #15
I haven't tested yet so uncertain if ready for merge.
I also wanted to ask it seems the Go implementation is different in that the
SetLocalefunction handles the fallback to English whereas the other implementations simply have theformatfunction handle the fallback. Is this intended?