🐛 fix: Fix createEdgeSpeech hangon#55
Open
sone47 wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR updates createEdgeSpeech to explicitly reject the promise when no audio data is returned, preventing the method from hanging indefinitely. Sequence diagram for createEdgeSpeech error handling on missing audio datasequenceDiagram
participant Caller
participant createEdgeSpeech
participant ws
Caller->>createEdgeSpeech: Call createEdgeSpeech()
createEdgeSpeech->>ws: Wait for 'turn.end' event
ws-->>createEdgeSpeech: 'turn.end' received
alt audioData.byteLength is 0
createEdgeSpeech-->>Caller: Reject promise with error
else audioData.byteLength > 0
createEdgeSpeech-->>Caller: Resolve promise with Response
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Member
|
👍 @sone47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
修复了当 audioData.byteLength 为空的时候,createEdgeSpeech 方法会一直挂起的问题。
📝 补充信息 | Additional Information
在某些情况下 edge tts api 不会返回语音数据,如 locale 语言设置错误,在英文语言下传入中文,这时 createEdgeSpeech 方法会一直挂起。
Summary by Sourcery
Bug Fixes: