writeState(): call fflush() before fsync() #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flush the libc buffers before calling fsync(). Otherwise the file content may not yet have been written to the kernel, and fsync() will not help in ensuring that the file data is written to disk.
Member
|
Looks good. Thanks for the patch! |
kdudka
added a commit
that referenced
this pull request
Oct 13, 2017
- make distribution tarballs report logrotate version properly [RHBZ#1500264](https://bugzilla.redhat.com/1500264) - make ```(un)compress work``` even if stdin and/or stdout are closed (#154) - remove ```-s``` from ```DEFAULT_MAIL_COMMAND``` and improve its documenation (#152) - uncompress logs before mailing them even if ```delaycompress``` is enabled (#151) - handle unlink of a non-existing log file as a warning only (#144) - include compile-time options in the output of ```logrotate --version``` (#145) - make ```logrotate --version``` print to stdout instead of stderr (#145) - flush write buffers before syncing state file (#148) - specify (un)compress utility explicitly in tests (#137) - enable running tests in parallel (#132) - explicitly map root UID/GID to 0 on Cygwin (#133) - add ```.dpkg-bak``` and ```.dpkg-del``` to default tabooext list (#134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flush the libc buffers before calling fsync().
Otherwise the file content may not yet have been written to the kernel,
and fsync() will not help in ensuring that the file data is written to
disk.