Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a sponsor section for Atlas Cloud to both the English and Chinese README files, along with the corresponding SVG logo assets. The reviewer provided feedback regarding security best practices for external links, suggesting the addition of rel="noopener noreferrer", and noted that the white logos may be invisible on light-themed backgrounds, recommending the use of theme-aware image tags.
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank"> | ||
| <img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/> | ||
| </a> | ||
|
|
||
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank"> | ||
| <img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/> | ||
| </a> |
There was a problem hiding this comment.
When using target="_blank" for external links, it is a security best practice to include rel="noopener noreferrer". This prevents the opened page from gaining access to the window.opener property of the original page, mitigating potential security risks such as tabnabbing.
Additionally, the sponsor logos provided (atlas-cloud-logomark-white.svg and atlas-cloud-logo-white.svg) are white. These will be invisible to users viewing the README in GitHub's light theme. Consider providing a version that is visible on light backgrounds or using theme-aware image tags (e.g., the <picture> element).
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank"> | |
| <img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/> | |
| </a> | |
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank"> | |
| <img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/> | |
| </a> | |
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank" rel="noopener noreferrer"> | |
| <img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/> | |
| </a> | |
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank" rel="noopener noreferrer"> | |
| <img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/> | |
| </a> |
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank"> | ||
| <img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/> | ||
| </a> | ||
|
|
||
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank"> | ||
| <img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/> | ||
| </a> |
There was a problem hiding this comment.
When using target="_blank" for external links, it is a security best practice to include rel="noopener noreferrer". This prevents the opened page from gaining access to the window.opener property of the original page, mitigating potential security risks.
Additionally, the sponsor logos provided are white, which makes them invisible to users viewing the README in GitHub's light theme. Consider providing a version that is visible on light backgrounds or using theme-aware image tags.
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank"> | |
| <img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/> | |
| </a> | |
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank"> | |
| <img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/> | |
| </a> | |
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank" rel="noopener noreferrer"> | |
| <img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/> | |
| </a> | |
| <a href="https://www.atlascloud.ai/console/coding-plan" target="_blank" rel="noopener noreferrer"> | |
| <img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/> | |
| </a> |
Greptile SummaryThis PR adds Atlas Cloud as a sponsor across the English, Chinese, and Japanese READMEs, along with four SVG logo assets (black and white variants of the full wordmark and logomark).
Confidence Score: 4/5Safe to merge for functional code, but the sponsor logos will not render correctly for GitHub dark-mode users. The only black-fill SVGs are linked in all three READMEs without any theme-switching mechanism. GitHub dark-mode users will see blank space where the sponsor logos should appear. The white-fill variants were added but are not referenced anywhere, leaving them unused. README.md, README.zh-CN.md, and README.ja-JP.md all have the same missing theme-aware image handling. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GitHub README render] --> B{User theme?}
B -->|Light mode| C[Black logos visible ✅]
B -->|Dark mode| D[Black logos on dark background ❌ invisible]
E[White SVGs added to repo] --> F[Not linked in any README]
F --> G[White logos never shown]
H[Fix: use theme-aware fragments] --> I["img src=...-black.svg#gh-light-mode-only"]
H --> J["img src=...-white.svg#gh-dark-mode-only"]
Reviews (3): Last reviewed commit: "docs: add Atlas Cloud sponsor section to..." | Re-trigger Greptile |
No description provided.