Skip to content

feat: introduce Atlas Cloud as sponsor#1693

Merged
looplj merged 2 commits into
unstablefrom
dev-tmp
May 22, 2026
Merged

feat: introduce Atlas Cloud as sponsor#1693
looplj merged 2 commits into
unstablefrom
dev-tmp

Conversation

@looplj

@looplj looplj commented May 22, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a sponsor section for Atlas Cloud to both the English and Chinese README files, along with the corresponding SVG logo assets. The reviewer provided feedback regarding security best practices for external links, suggesting the addition of rel="noopener noreferrer", and noted that the white logos may be invisible on light-themed backgrounds, recommending the use of theme-aware image tags.

Comment thread README.md Outdated
Comment on lines +34 to +40
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank">
<img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/>
</a>

<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank">
<img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/>
</a>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When using target="_blank" for external links, it is a security best practice to include rel="noopener noreferrer". This prevents the opened page from gaining access to the window.opener property of the original page, mitigating potential security risks such as tabnabbing.

Additionally, the sponsor logos provided (atlas-cloud-logomark-white.svg and atlas-cloud-logo-white.svg) are white. These will be invisible to users viewing the README in GitHub's light theme. Consider providing a version that is visible on light backgrounds or using theme-aware image tags (e.g., the <picture> element).

Suggested change
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank">
<img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/>
</a>
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank">
<img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/>
</a>
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank" rel="noopener noreferrer">
<img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/>
</a>
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank" rel="noopener noreferrer">
<img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/>
</a>

Comment thread README.zh-CN.md Outdated
Comment on lines +34 to +40
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank">
<img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/>
</a>

<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank">
<img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/>
</a>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When using target="_blank" for external links, it is a security best practice to include rel="noopener noreferrer". This prevents the opened page from gaining access to the window.opener property of the original page, mitigating potential security risks.

Additionally, the sponsor logos provided are white, which makes them invisible to users viewing the README in GitHub's light theme. Consider providing a version that is visible on light backgrounds or using theme-aware image tags.

Suggested change
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank">
<img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/>
</a>
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank">
<img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/>
</a>
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank" rel="noopener noreferrer">
<img src="docs/sponsors/atlas-cloud-logomark-white.svg" alt="Atlas Cloud" width="60"/>
</a>
<a href="https://www.atlascloud.ai/console/coding-plan" target="_blank" rel="noopener noreferrer">
<img src="docs/sponsors/atlas-cloud-logo-white.svg" alt="Atlas Cloud" width="200"/>
</a>

@greptile-apps

greptile-apps Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds Atlas Cloud as a sponsor across the English, Chinese, and Japanese READMEs, along with four SVG logo assets (black and white variants of the full wordmark and logomark).

  • All three READMEs reference only the black-fill SVG variants; the white-fill variants are added to the repository but never linked.
  • No GitHub theme-aware image switching (#gh-light-mode-only / #gh-dark-mode-only) is used, so the black logos will be invisible to readers viewing the READMEs in GitHub dark mode.

Confidence Score: 4/5

Safe to merge for functional code, but the sponsor logos will not render correctly for GitHub dark-mode users.

The only black-fill SVGs are linked in all three READMEs without any theme-switching mechanism. GitHub dark-mode users will see blank space where the sponsor logos should appear. The white-fill variants were added but are not referenced anywhere, leaving them unused.

README.md, README.zh-CN.md, and README.ja-JP.md all have the same missing theme-aware image handling.

Important Files Changed

Filename Overview
README.md Sponsor section added using only black-fill SVGs; logos will be invisible to GitHub dark-mode users.
README.zh-CN.md Same black-only SVG issue as README.md — logos invisible in dark mode.
README.ja-JP.md Same black-only SVG issue as the other READMEs — logos invisible in dark mode.
docs/sponsors/atlas-cloud-logo-black.svg Black-fill full-wordmark SVG added; correctly uses fill: #000.
docs/sponsors/atlas-cloud-logo-white.svg White-fill full-wordmark SVG added but not referenced in any README.
docs/sponsors/atlas-cloud-logomark-black.svg Black-fill logomark SVG added; correctly uses fill: #000.
docs/sponsors/atlas-cloud-logomark-white.svg White-fill logomark SVG added but not referenced in any README.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[GitHub README render] --> B{User theme?}
    B -->|Light mode| C[Black logos visible ✅]
    B -->|Dark mode| D[Black logos on dark background ❌ invisible]

    E[White SVGs added to repo] --> F[Not linked in any README]
    F --> G[White logos never shown]

    H[Fix: use theme-aware fragments] --> I["img src=...-black.svg#gh-light-mode-only"]
    H --> J["img src=...-white.svg#gh-dark-mode-only"]
Loading

Reviews (3): Last reviewed commit: "docs: add Atlas Cloud sponsor section to..." | Re-trigger Greptile

Comment thread README.md Outdated
Comment thread README.zh-CN.md Outdated
@looplj looplj merged commit 23e553d into unstable May 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant