DeepSeek CoT Support for Filter and Map #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
extract_deepseek_cot.py is broken right now. Getting APIconnectionError. Running Deepseek on Ollama, but issue with function_call['name']. Seems to be Litellm error |
Collaborator
|
The user shouldn't need to specify the type of reasoning -- we should set it based on the model, or just take the output string and check whether there is a token or something else |
sidjha1
reviewed
Mar 20, 2025
sidjha1
reviewed
Mar 31, 2025
lotus/sem_ops/sem_map.py
Outdated
|
|
||
| # post process results | ||
| postprocess_output = postprocessor(lm_output.outputs, strategy in ["cot", "zs-cot"]) | ||
| postprocess_output = postprocessor(lm_output.outputs, model, strategy in ["cot", "zs-cot"]) |
Collaborator
There was a problem hiding this comment.
We could consider having class ReasoningStrategy(Enum) to be more clear on what all the different methods are. As I read the code, it feels things are getting a bit unwieldy.
sidjha1
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces CoT for
sem_extractas well as supporting DeepSeek-R1 CoT for other semantic operators.Example output with
sem_map:Example output with
sem_filter:Users will need to specify the reasoning_parser. Example:
df = df.sem_map(user_instruction, return_explanations=True, strategy=ReasoningStrategy.ZS_COT)New Type for models:
ReasoningStrategy(Enum)