Skip to content

Conversation

@JRedOW
Copy link
Contributor

@JRedOW JRedOW commented Feb 16, 2025

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Automatically refresh the certificate expiry on status pages when enabled.

Fixes #5059

Avoided E2E tests as certificate expiry on status pages are currently marked TODO. I can add api unit tests if needed (though the code is pretty simple and replicated elsewhere).

Can be merged by junior (probably @CommanderStorm since you interacted with the original issue) as there aren't any breaking changes and the changes just match an average user's expected behavior.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label Feb 16, 2025
@JRedOW JRedOW force-pushed the status-certificate-refreshing branch from e0be998 to e441b6d Compare March 11, 2025 02:55
Copy link
Contributor

@Ionys320 Ionys320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue for me.

I would just suggest avoiding code duplication and create a util or something to simplify maintenance, but I know we copy-paste some code from time to time, so it's not a big deal at my point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:needs review this PR needs a review by maintainers or other community members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certificate expiration days are not refreshed automatically

3 participants