feat: make mariadb max pool connections controllable via env #6386

amirparsadd · 2025-11-20T16:42:14Z

📋 Overview

I saw an issue saying that mariadb max connections should be controllable through env variables so this PR fixes that with a new env variable:

MARIADB_POOL_MAX_CONNECTIONS

Resolves Configurable maximum parallel MariaDB connections #6374

🛠️ Type of change

🐛 Bugfix (a non-breaking change that resolves an issue)
✨ New feature (a non-breaking change that adds new functionality)
⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
🎨 User Interface (UI) updates
📄 New Documentation (addition of new documentation)
📄 Documentation Update (modification of existing documentation)
📄 Documentation Update Required (the change requires updates to related documentation)
🔧 Other (please specify):
- Provide additional details here.

📄 Checklist

📷 Screenshots or Visual Changes

CommanderStorm

Could you please make sure that all environment variables stick to our existing naming scheme

https://github.com/louislam/uptime-kuma/wiki/Environment-Variables#mariadb-environment-variables

I am also not entirely sure if the min pool size should be configurable. What is the effect there?

amirparsadd · 2025-11-21T08:30:22Z

Could you please make sure that all environment variables stick to our existing naming scheme

https://github.com/louislam/uptime-kuma/wiki/Environment-Variables#mariadb-environment-variables

I am also not entirely sure if the min pool size should be configurable. What is the effect there?

It's now following standards and i removed the min connections env

louislam · 2025-11-21T11:02:15Z

I think it needs some validations. Like checking a empty string, NaN etc. Or maybe number range.

CommanderStorm

LGTM now, thanks 🙏
Should be uncontroversial and help the few people on a limited pool Mariadb hoster

…me-kuma into mriadb-pool-env

amirparsadd · 2025-11-21T11:26:40Z

@CommanderStorm i added validation as Louis said

CommanderStorm

Please polish your code one round.

Please instead default to 10 and then add an if statement if the env var contains a valid number.
Number.MAX_SAFE_INTEGER for example is not a sensible max.

Also please log if a value does not get applied.

louislam · 2025-11-22T09:29:46Z

Plus, you don't need to call parseInt 4 times.

amirparsadd · 2025-11-24T13:28:05Z

Changes:

added reasonable max
added logging on fail
removed repetitive parseInt

amirparsadd · 2025-11-25T10:32:24Z

@CommanderStorm This is ready

CommanderStorm

The code isn’t yet at a level where I can merge it.
I’ve given more detailed feedback this time - please incorporate those changes, and then we can move forward.

server/database.js

CommanderStorm

I still think that the code quality does not 100% meet what I would like the code to be in terms of readability.

What do you think of my variant of writing ths

CommanderStorm · 2025-11-27T20:23:57Z

server/database.js

+        let parsedMaxPoolConnections = parseInt(process.env.UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS);
+        let error = undefined;
+
+        if (!process.env.UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS || Number.isNaN(parsedMaxPoolConnections)) {
+            error = "invalid";
+        } else if (parsedMaxPoolConnections < 1) {
+            error = "less than 1";
+        } else if (parsedMaxPoolConnections > 100) {
+            error = "more than 100";
+            log.warn("db", "We cap pool connections because Mysql/Mariadb connections are heavy. consider using a proxy like ProxySQL or MaxScale.");
+        }
+
+        if (error) {
+            log.warn("db", `Max database connections defaulted to 10 because UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS was ${error}.`);
+        } else {
+            log.info("db", `Max database connections: ${parsedMaxPoolConnections}`);
+        }


Your switching on error way of writing this is fairly hard to read.
Lets simplify

Suggested change

let parsedMaxPoolConnections = parseInt(process.env.UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS);

let error = undefined;

if (!process.env.UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS || Number.isNaN(parsedMaxPoolConnections)) {

error = "invalid";

} else if (parsedMaxPoolConnections < 1) {

error = "less than 1";

} else if (parsedMaxPoolConnections > 100) {

error = "more than 100";

log.warn("db", "We cap pool connections because Mysql/Mariadb connections are heavy. consider using a proxy like ProxySQL or MaxScale.");

}

if (error) {

log.warn("db", `Max database connections defaulted to 10 because UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS was ${error}.`);

} else {

log.info("db", `Max database connections: ${parsedMaxPoolConnections}`);

}

let parsedMaxPoolConnections = parseInt(process.env.UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS);

if (!process.env.UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS) {

parsedMaxPoolConnections = 10;

} else if (Number.isNaN(parsedMaxPoolConnections)) {

log.warn("db", "Max database connections defaulted to 10 because UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS was invalid.");

parsedMaxPoolConnections = 10;

} else if (parsedMaxPoolConnections < 1) {

log.warn("db", "Max database connections defaulted to 10 because UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS was less than 1.");

parsedMaxPoolConnections = 10;

} else if (parsedMaxPoolConnections > 100) {

log.warn("db", "Max database connections capped to 100 because Mysql/Mariadb connections are heavy. consider using a proxy like ProxySQL or MaxScale.");

parsedMaxPoolConnections = 100;

}

CommanderStorm · 2025-11-27T20:24:28Z

server/database.js

        let mariadbPoolConfig = {
            min: 0,
-            max: 10,
+            max: error ? 10 : parsedMaxPoolConnections,


Suggested change

max: error ? 10 : parsedMaxPoolConnections,

max: parsedMaxPoolConnections,

make mariadb pool connections controllable through env variables

a5ae7e4

CommanderStorm requested changes Nov 21, 2025

View reviewed changes

rename env var to match standards and remove min env var

79c83e4

CommanderStorm approved these changes Nov 21, 2025

View reviewed changes

CommanderStorm added this to the 2.1.0 milestone Nov 21, 2025

Merge branch 'master' into mriadb-pool-env

fcef142

CommanderStorm enabled auto-merge (squash) November 21, 2025 11:04

Amirparsa Baghdadi added 2 commits November 21, 2025 14:54

add validation to UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS

4a6798a

Merge branch 'mriadb-pool-env' of https://github.com/amirparsadd/upti…

9103982

…me-kuma into mriadb-pool-env

auto-merge was automatically disabled November 21, 2025 11:25
Head branch was pushed to by a user without write access

CommanderStorm requested changes Nov 22, 2025

View reviewed changes

CommanderStorm changed the title ~~make mariadb pool connections controllable through env variables~~ feat: make mariadb max pool connections controllable through env variables Nov 23, 2025

CommanderStorm changed the title ~~feat: make mariadb max pool connections controllable through env variables~~ feat: make mariadb max pool connections controllable via env Nov 23, 2025

Amirparsa Baghdadi and others added 5 commits November 24, 2025 16:48

remove repetetive parseInt

249ee7e

set a logical max pool connections

99a3eac

use const var for default max pool connections

05c4257

add log if UPTIME_KUMA_DB_POOL_MAX_CONNECTIONS was invalid

ee231ae

Merge branch 'master' into mriadb-pool-env

fdcf39d

added note on why theres a limit on max pool connections

518d34c

CommanderStorm requested changes Nov 25, 2025

View reviewed changes

server/database.js Outdated Show resolved Hide resolved

server/database.js Outdated Show resolved Hide resolved

server/database.js Outdated Show resolved Hide resolved

server/database.js Outdated Show resolved Hide resolved

Amirparsa Baghdadi and others added 3 commits November 26, 2025 11:12

improve how error handling is done

5b3ae6e

added log for max database connection

cfb4b2f

Merge branch 'master' into mriadb-pool-env

781f97e

louislam mentioned this pull request Nov 27, 2025

Uptime Kuma with MariaDB docker-compose, and max connection pool conf… #6426

Closed

2 tasks

CommanderStorm requested changes Nov 27, 2025

View reviewed changes

louislam mentioned this pull request Nov 28, 2025

docs: Add MariaDB connection pool configuration guide louislam/uptime-kuma-wiki#133

Closed

CommanderStorm mentioned this pull request Nov 28, 2025

Postgres support #959

Open

1 task

	max: error ? 10 : parsedMaxPoolConnections,
	max: parsedMaxPoolConnections,

Uh oh!

feat: make mariadb max pool connections controllable via env #6386

Are you sure you want to change the base?

feat: make mariadb max pool connections controllable via env #6386

Conversation

amirparsadd commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 Overview

🛠️ Type of change

📄 Checklist

📷 Screenshots or Visual Changes

Uh oh!

CommanderStorm left a comment

Choose a reason for hiding this comment

Uh oh!

amirparsadd commented Nov 21, 2025

Uh oh!

louislam commented Nov 21, 2025

Uh oh!

CommanderStorm left a comment

Choose a reason for hiding this comment

Uh oh!

amirparsadd commented Nov 21, 2025

Uh oh!

CommanderStorm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

louislam commented Nov 22, 2025

Uh oh!

amirparsadd commented Nov 24, 2025

Uh oh!

amirparsadd commented Nov 25, 2025

Uh oh!

CommanderStorm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CommanderStorm left a comment

Choose a reason for hiding this comment

Uh oh!

CommanderStorm Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

CommanderStorm Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amirparsadd commented Nov 20, 2025 •

edited

Loading

CommanderStorm left a comment •

edited

Loading