The PR will fix #786 .

💪 Motivation

In order to minimize future security risks and maintain ease of use, it is recommended to avoid using deprecated features of clap.

✅ What I did

I have refactored the code so that no warning appears when the following command is executed:

cargo check --features clap/deprecated

This command was introduced for migration to v4, but we can use it here.

🔄 Main Changes

also see 👀 : https://github.com/clap-rs/clap/blob/master/CHANGELOG.md

in app.rs ...

• App -> Command
  • App is just an alias of Command in this version, so we can replace it.
  • 💻 : clap/src/builder/command.rs#L70
  • 📝 : related CHANGELOG
• use Arg::action
  • use ArgAction::Append instead of Arg::take_value
  • use ArgAction::SetTrue for bool flags (like lsd -a)
• Arg::validator -> Arg::value_parser
  • I changed the validator's type and it returns Ok(validated_value).
  • 📝 related Doc (use Fn(&str) -> Result<T, E> pattern.)

in flags/*.rs ...

• Command::get_matches_from_safe -> Command::try_get_matches_from
  • Command::get_matches_from_safe is just an alias of Command::try_get_matches_from, so we can replace it.
  • 💻 : clap/src/builder/command.rs#L4081
• ArgMatches::is_present -> ArgMatches::get_one::<bool>
  • 📝 : related CHANGELOG
• ArgMatches::occurrences_of(id) > 0 -> ArgMatches::value_source(id) == ValueSource::CommandLine
  • ArgMatches::occurrences_of(id) returns the number of times an argument was used at runtime, so we can replace it with ValueSource::CommandLine check.
  • 📝 : related CHANGELOG
• ArgMatches::values_of -> ArgMatches::get_many::<T>
• ArgMatches::value_of -> ArgMatches::get_one::<T>
  • In many place I used ArgMatches::get_*::<String> and then map(String::as_str) to conform to existing codes which uses &str.

💭 Comments

• There are a lot of commits because of my habits. Please inform me if it is too many.

TODO

• Use cargo fmt
• Add necessary tests
• Add changelog entry
• Update default config/theme in README (if applicable)
• Update man page at lsd/doc/lsd.md (if applicable)