Adding some more icons for filenames and extensions#929
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Babkock The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #929 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 51 51
Lines 5001 5001
=======================================
Hits 4289 4289
Misses 712 712 ☔ View full report in Codecov by Sentry. |
|
Hello, I have fixed the CI tests. |
|
hi @Babkock, thanks for contributing, but I would prefer to keep the origin icons if there are no strong reasons to change them, it may break the existed users |
Which original icons, specifically? I think the Rust, subtitle, and Emacs icon changes should stay; are you talking about those, or the ones for Music, Downloads, Pictures, etc.? |
zwpaper
left a comment
There was a problem hiding this comment.
never mind, it seems reasonable to change at a second thought.
but found 2 nits
| (".sqlite_history", "\u{e7c4}"), // "" | ||
| ("src", "\u{f121}"), // "" | ||
| (".ssh", "\u{f023}"), // "" | ||
| ("src", "\u{f19fc}"), // "" |
There was a problem hiding this comment.
it seems that the origin one is showing source code, and the new one could not
There was a problem hiding this comment.
I can change this back if you want.
|
Hi @Babkock, thanks so much for contributing, all the icons look great but the and we could also change the |
I think I wanted the I have pushed some fixes, and added a couple icons that were missing. |
I agree with you on this one,
but not this one. I also seek for a better one but failed. |
|
for the |
Ohh, okay. So that I apologize for any confusion. Are we on the same page? Did I address your concern? Is there anything you would like me to change? |
Hello, I hope you all are doing well. I committed to this repository a little over a year ago, when I made a pull request like this one, suggesting ideas for icons. Many of these icon -> extension associations were taken from eza, because that project has many icons that this project does not have yet. I have a pull request pending on that repo, too. Please look over my changed file, but to save you some time here's the summary of what I've done:
\u{e68b})config.el,packages.eletc.) to use the actual Emacs icon instead of GNU head for Emacs files (\u{e632}).pl,.pm,.pod,.plx) now use the camel instead of the... circle (\u{e67e}).ml,.mli,.mll)You will notice I changed many of the existing icons in place for standard folder/directory name matches, such as in the home directory ("Pictures", "Music", "Downloads" now are actual folder icons) and in the root directory ("bin", "src"). These are in a separate commit, so if you aren't feeling those particular icons, we can roll it back to how those icons were before.
Thank you very much for your time. I welcome any and all feedback, and I will make more commits if necessary.
For reference