enable CI build workflow on PRs #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
051da02 to
3836e31
Compare
Signed-off-by: Ryan Goodfellow <ryan.goodfellow@oxide.computer>
3836e31 to
ab0a0a6
Compare
jonathan-dilorenzo
approved these changes
Mar 31, 2025
Collaborator
jonathan-dilorenzo
left a comment
There was a problem hiding this comment.
This is great! Is there somewhere I can see the spec associated e.g. with this PR (even though it would be unchanged) just to see an example of this in action?
Collaborator
Author
yeah, if you click on one of the successful jobs with the green checkmark next to it, and then click on "summary" in the upper left hand part of the web page, you should be able to download the CI produced artifacts. |
Collaborator
|
Super cool. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so that CI is run for pull requests. This is helpful when reviewing request and for PR submitters to see the CI rendering of spec changes.