Fix SIGSEGV when v1model version is negative or invalid #5436

jhavrane · 2025-12-09T09:23:04Z

Adds missing validation for v1model value constant. Fixes #5296

Signed-off-by: Jiri Havranek <jiri.havranek@altera.com>

jhavrane · 2025-12-09T09:26:42Z

Also tried with value from the issue:

Error compiling
issue5296.p4(2): [--Werror=expected] error: error.pkt: expected v1model version to be a non-negative number
const bit<32> __v1model_version = error.pkt;
                                  ^^^^^^^^^

ChrisDodd · 2025-12-09T11:05:07Z

frontends/p4/getV1ModelVersion.h

    bool preorder(const IR::Declaration_Constant *dc) override {
        if (dc->name == "__v1model_version") {
            const auto *val = dc->initializer->to<IR::Constant>();
+            if (!val) {


Probably should be if (!val || val->value < 0). The only reason this seems to work without it is because -6419018 is initially IR::Neg on an IR::Constant, and if constant-folding runs it will be simplified.

Might also want to limit it to just known valid versions of V1MODEL_VERSION

@ChrisDodd, is there any list of valid versions of V1MODEL_VERSION somewhere?

Grepped this list of versions from testdata/

20160101 20180000 20180101 20200000 20200408

Signed-off-by: Jiri Havranek <jiri.havranek@altera.com>

Signed-off-by: Kyle Cripps <kyle@pensando.io>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Signed-off-by: Michal Kekely <michal.kekely@altera.com>

Signed-off-by: Mouse <mouse@mojatatu.com> Signed-off-by: Victor Nogueira <victor@mojatatu.com> Co-authored-by: Mouse <mouse@mojatatu.com>

Signed-off-by: Victor Nogueira <victor@mojatatu.com>

Signed-off-by: Bryan Richter <b@chreekat.net>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: fruffy <fruffy@nyu.edu>

…n the `ErrorCatalog` (p4lang#5360) Signed-off-by: kfcripps <kyle@pensando.io>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Vineet1101 <Vineetgoel692@gmail.com>

Signed-off-by: KunJeong <kunjeong99@naver.com>

…5366) Signed-off-by: djparker21 <drparker@amd.com>

Signed-off-by: Bryan Richter <b@chreekat.net>

Signed-off-by: fruffy <fruffy@nyu.edu>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

…ng#5393) Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Signed-off-by: Bryan Richter <b@chreekat.net>

Signed-off-by: Kyle Cripps <kyle@pensando.io>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Signed-off-by: Bryan Richter <b@chreekat.net>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Signed-off-by: Victor Nogueira <victor@mojatatu.com> Co-authored-by: Jamal Hadi Salim <jhs@mojatatu.com>

Signed-off-by: Victor Nogueira <victor@mojatatu.com> Co-authored-by: Jamal Hadi Salim <jhs@mojatatu.com> Co-authored-by: Pedro Tammela <pctammela@mojatatu.com>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Co-authored-by: rst0git <9142901+rst0git@users.noreply.github.com>

Signed-off-by: fruffy <fruffy@nyu.edu>

…king again (p4lang#5424) Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu> Signed-off-by: fruffy <fruffy@nyu.edu> Co-authored-by: fruffy <fruffy@nyu.edu>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

…actually valid (p4lang#5417) Signed-off-by: fruffy <fruffy@nyu.edu>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Signed-off-by: Victor Nogueira <victor@mojatatu.com> Co-authored-by: Jamal Hadi Salim <jhs@mojatatu.com> Co-authored-by: Pedro Tammela <pctammela@mojatatu.com>

Co-authored-by: rst0git <9142901+rst0git@users.noreply.github.com>

Signed-off-by: Vladimir Still <dev.p4@vstill.eu> Signed-off-by: Denis Matousek <denis.matousek@altera.com> Co-authored-by: Denis Matousek <denis.matousek@altera.com>

Signed-off-by: Vladimír Štill <vladimir.still@altera.com> Signed-off-by: Denis Matousek <denis.matousek@altera.com> Co-authored-by: Denis Matousek <denis.matousek@altera.com>

…4lang#5432) Signed-off-by: djparker21 <drparker@amd.com>

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Signed-off-by: Vladimír Štill <vladimir.still@altera.com> Signed-off-by: Denis Matousek <denis.matousek@altera.com> Co-authored-by: Vladimír Štill <vladimir.still@altera.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Jiri Havranek <jiri.havranek@altera.com>

Fix SIGSEGV when v1model version is negative

f9aaaa2

Signed-off-by: Jiri Havranek <jiri.havranek@altera.com>

jhavrane self-assigned this Dec 9, 2025

ChrisDodd reviewed Dec 9, 2025

View reviewed changes

fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Dec 10, 2025

jhavrane and others added 25 commits December 12, 2025 09:27

Improve v1 model value checking

9de6ed4

Signed-off-by: Jiri Havranek <jiri.havranek@altera.com>

Coding style fixes

57fba01

Signed-off-by: Jiri Havranek <jiri.havranek@altera.com>

Add back test case for p4lang#5333 (p4lang#5351)

2691926

Signed-off-by: Kyle Cripps <kyle@pensando.io>

Print warnings in a deterministic order (p4lang#5352)

418f621

Signed-off-by: Kyle Cripps <kyle@pensando.io>

ensure child of IR::SwitchCase remains a BlockStatement (p4lang#5349)

8c9b6f8

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Extended Type_InfInt handling in ExpressionEvaluator (p4lang#5355)

f384cf3

Signed-off-by: Michal Kekely <michal.kekely@altera.com>

Fixed SIGSEGV crash in struct assign (p4lang#5356)

4d0f202

Signed-off-by: Michal Kekely <michal.kekely@altera.com>

Add support for operations on value with sizes > 64-bit (p4lang#5345)

edcd0c8

Signed-off-by: Mouse <mouse@mojatatu.com> Signed-off-by: Victor Nogueira <victor@mojatatu.com> Co-authored-by: Mouse <mouse@mojatatu.com>

Make struct used by digest in p4tc packed (p4lang#5329)

aea258e

Signed-off-by: Victor Nogueira <victor@mojatatu.com>

Add Checksum extern support to the TC backend (p4lang#5357)

34df976

Signed-off-by: Victor Nogueira <victor@mojatatu.com>

Add Random extern support to the TC backend (p4lang#5354)

b6135be

Signed-off-by: Victor Nogueira <victor@mojatatu.com>

Print message when P4TEST_IGNORE_STDERR is used (p4lang#5358)

9fa308b

Signed-off-by: Bryan Richter <b@chreekat.net>

Extension to strength reduction for issue 5280 (p4lang#5281)

d60891b

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Bump actions/checkout from 4 to 5 (p4lang#5363)

7f087a0

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Make building the control-plane (and protobuf) optional. (p4lang#5368)

d0cb112

Signed-off-by: fruffy <fruffy@nyu.edu>

[p4lang#5350] Replace underscores with hyphens for diagnostic types i…

b6414ff

…n the `ErrorCatalog` (p4lang#5360) Signed-off-by: kfcripps <kyle@pensando.io>

Bump actions/github-script from 7 to 8 (p4lang#5374)

74e426f

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump actions/setup-python from 5 to 6 (p4lang#5373)

b813379

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[docs] Added test guide (p4lang#5215)

69008d4

Signed-off-by: Vineet1101 <Vineetgoel692@gmail.com>

Add 248 negative tests to p4_16_errors (p4lang#5369)

922a309

Signed-off-by: KunJeong <kunjeong99@naver.com>

Remove unnecessary table stepper object from pna exr_stepper (p4lang#…

f7d2c5b

…5366) Signed-off-by: djparker21 <drparker@amd.com>

Small build cleanups (p4lang#5388)

a297712

Signed-off-by: Bryan Richter <b@chreekat.net>

Remove GetV1ModelVersion from front end (p4lang#5390)

4a4d2aa

Signed-off-by: fruffy <fruffy@nyu.edu>

Support for arrays of extern instances (p4lang#5338)

c684bf4

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Fix gtestasm (tests now throw CompilerBug rather than aborting) (p4la…

a771b93

…ng#5393) Signed-off-by: Chris Dodd <cdodd@nvidia.com>

dependabot bot and others added 30 commits December 19, 2025 11:33

Bump peter-evans/find-comment from 3 to 4 (p4lang#5396)

f505f36

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump peter-evans/create-or-update-comment from 4 to 5 (p4lang#5395)

bad5451

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Fix simplifySwitch handling of enums (p4lang#5365)

105f973

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Prevent unintended backtick parsing (p4lang#5397)

36bc401

Signed-off-by: Bryan Richter <b@chreekat.net>

Increase minimum required BISON version to 3.1 (p4lang#5398)

db7a0ab

Signed-off-by: Kyle Cripps <kyle@pensando.io>

Fix EliminateTuples bug with nested struct/tuples (p4lang#5362)

8f05625

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Bump grpcio for Mac (p4lang#5404)

be444b7

Signed-off-by: Bryan Richter <b@chreekat.net>

Avoid 'fatal error : Broken pipe' from preprocessor (p4lang#5400)

931f55d

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

JSON error checking when loading (p4lang#5401)

8e7f250

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Add redirect_l2 test case (p4lang#5406)

fedef36

Signed-off-by: Victor Nogueira <victor@mojatatu.com> Co-authored-by: Jamal Hadi Salim <jhs@mojatatu.com>

Add p4tc routing testcases (p4lang#5409)

cb1eea3

Signed-off-by: Victor Nogueira <victor@mojatatu.com> Co-authored-by: Jamal Hadi Salim <jhs@mojatatu.com> Co-authored-by: Pedro Tammela <pctammela@mojatatu.com>

Fix/reorganize to/fromJSON code (p4lang#5403)

ab5e39f

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Automated Release v1.2.5.9 (p4lang#5413)

65922b6

Co-authored-by: rst0git <9142901+rst0git@users.noreply.github.com>

Fixes for P4-14 Tofino compilation. (p4lang#5414)

387447a

Signed-off-by: fruffy <fruffy@nyu.edu>

Temporarily disable use of p4lang-bmv2 Debian package until it is wor…

9d46f77

…king again (p4lang#5424) Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu> Signed-off-by: fruffy <fruffy@nyu.edu> Co-authored-by: fruffy <fruffy@nyu.edu>

fix return types of fromJSON to match NodeFactoryFn (p4lang#5420)

8c24a1f

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Add validation to make sure source info generated from the parser is …

f7e45cb

…actually valid (p4lang#5417) Signed-off-by: fruffy <fruffy@nyu.edu>

Bump actions/checkout from 5 to 6 (p4lang#5426)

00cd489

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Silence 'unused' warnings for stuff in tofino headers (p4lang#5427)

92c771a

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Add p4tc IP-in-IP testcases (p4lang#5431)

5087070

Signed-off-by: Victor Nogueira <victor@mojatatu.com> Co-authored-by: Jamal Hadi Salim <jhs@mojatatu.com> Co-authored-by: Pedro Tammela <pctammela@mojatatu.com>

Automated Release v1.2.5.10 (p4lang#5429)

63b1fff

Co-authored-by: rst0git <9142901+rst0git@users.noreply.github.com>

Fix segmentation failure in ConstantTypeSubstitution (p4lang#5271)

fe82d45

Signed-off-by: Vladimir Still <dev.p4@vstill.eu> Signed-off-by: Denis Matousek <denis.matousek@altera.com> Co-authored-by: Denis Matousek <denis.matousek@altera.com>

Fix handling of int<0> constants, fix warning category (p4lang#5249)

8d89f25

Signed-off-by: Vladimír Štill <vladimir.still@altera.com> Signed-off-by: Denis Matousek <denis.matousek@altera.com> Co-authored-by: Denis Matousek <denis.matousek@altera.com>

Add parser state tracking, testgen option for parser state tracking (p…

b5a6783

…4lang#5432) Signed-off-by: djparker21 <drparker@amd.com>

Improvements in strength reduction for comparisons (p4lang#5434)

f0e99b7

Signed-off-by: Chris Dodd <cdodd@nvidia.com>

Type check that RHS of shift is integral type (p4lang#5446)

766740a

Signed-off-by: Vladimír Štill <vladimir.still@altera.com> Signed-off-by: Denis Matousek <denis.matousek@altera.com> Co-authored-by: Vladimír Štill <vladimir.still@altera.com>

Bump actions/cache from 4 to 5 (p4lang#5449)

2303b98

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump peter-evans/create-pull-request from 7 to 8 (p4lang#5448)

4763c70

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add checks for plus slice values (p4lang#5442)

6e384ad

Signed-off-by: Jiri Havranek <jiri.havranek@altera.com>

Add missing reference file

8592af7

Signed-off-by: Jiri Havranek <jiri.havranek@altera.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SIGSEGV when v1model version is negative or invalid #5436

Fix SIGSEGV when v1model version is negative or invalid #5436

jhavrane commented Dec 9, 2025

Uh oh!

jhavrane commented Dec 9, 2025

Uh oh!

ChrisDodd Dec 9, 2025

Uh oh!

jhavrane Dec 12, 2025

Uh oh!

jhavrane Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Fix SIGSEGV when v1model version is negative or invalid #5436

Are you sure you want to change the base?

Fix SIGSEGV when v1model version is negative or invalid #5436

Conversation

jhavrane commented Dec 9, 2025

Uh oh!

jhavrane commented Dec 9, 2025

Uh oh!

ChrisDodd Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

jhavrane Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

jhavrane Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants