Nx Go Support #172
Merged
Nx Go Support #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptr727
requested changes
Aug 29, 2024
Owner
ptr727
left a comment
There was a problem hiding this comment.
Thank you for the PR, please address the requested changes.
Owner
|
Please make the required changes to e.g. [https://github.com/ptr727/NxWitness/blob/main/Make/Instructions.sh] echo'ing the new port numbers assigned in the compose stack, as well as build.sh, clean.sh, etc., and test locally. And add |
Contributor
Author
|
Please see updates. Also targeted README Docker Hub information. Pending local testing, I will have updates tomorrow. |
Owner
|
All builds passed, I merged the change, if you find any issues feel free to PR again, please PR against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nx Go Dockerfile generation support.