Skip to content

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Aug 19, 2017

There is one more case I do not know how to fix:

In the response.text() description, type of return value misses the reference. Please, let me know if I can add one for the [text] link.

@aslushnikov
Copy link
Contributor

aslushnikov commented Aug 20, 2017

In the response.text() description, type of return value misses the reference. Please, let me know if I can add one for the [text] link.

ah, thanks. It is supposed to be Promise of string. Fixed in ab125f6

@aslushnikov aslushnikov merged commit 9ede314 into puppeteer:master Aug 20, 2017
@vsemozhetbyt vsemozhetbyt deleted the fix-links branch August 20, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants