Put chrome profiles into a temporary directory #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Aug 21, 2017
There was a problem hiding this comment.
The SIGINT is handled in #434.
but that would break if users have their own SIGINT handler.
Can you provide an example?
lib/Launcher.js
Outdated
There was a problem hiding this comment.
does this work on windows? For some reason, chrome launcher has a bunch of heuristics to infer tmp directory
There was a problem hiding this comment.
It also turned out there's a fs.mkdtemp - let's use it in favor of current folder name generation.
43c069d to
b749019
Compare
b749019 to
22b5215
Compare
aslushnikov
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed I had a lot of old .dev-profile folders from when I used Ctrl+C to end Puppeteer. I thought about cleaning up on SIGINT, but that would break if users have their own SIGINT handler. So maybe putting the profiles into a temp directory will at least stop them from piling up forever.