Skip to content

Allow a custom userDataDir to be specified #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2017
Merged

Allow a custom userDataDir to be specified #555

merged 2 commits into from
Aug 28, 2017

Conversation

@JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Aug 26, 2017

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Aug 26, 2017

Thank you!
Do I get this right?

  1. If I set the path to a real user dir from, say, Google Chrome, it will be used properly and will not be corrupted?
  2. If I set the path to an empty dir, all the necessary files will be created and will be used properly on next launches?

@JoelEinbinder
Copy link
Contributor Author

JoelEinbinder commented Aug 26, 2017

@vsemozhetbyt sounds right. I still have to look into what is going on with #527 though.

aslushnikov
aslushnikov approved these changes Aug 27, 2017
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Let's land this after #566

@aslushnikov aslushnikov merged commit d5327e6 into puppeteer:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoelEinbinder @vsemozhetbyt @aslushnikov