Fix Request Interception #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that either Network.requestIntercepted or Network.requestWillBeSent occasionally report encoded URL. This patch starts decoding URL's when generating request hash. Fixes puppeteer#558.
JoelEinbinder
approved these changes
Aug 27, 2017
|
I have found another url that breaks in the same way (load never fires) when using EnvironmentPuppeteer: const puppeteer = require('puppeteer');
(async() => {
const browser = await puppeteer.launch({
ignoreHTTPSErrors: true,
args: ['--disable-setuid-sandbox', '--no-sandbox']
})
const page = await browser.newPage()
// with setRequestInterceptionEnabled(true)..
await page.setRequestInterceptionEnabled(true)
// ..page.load never fires for this url.
await page.goto('https://www.studentdebtrelief.us/')
console.log('page load DONE') // never happens
browser.close();
})();Let me know if you want me to open a new issue for this. |
|
@pocketjoso that definitely deserves a new issue, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that either
Network.requestInterceptedorNetwork.requestWillBeSentoccasionally report encoded URL.Upstream bug: https://crbug.com/759388
As a workaround, this patch starts decoding URL's when generating request hash.
Fixes #558.