TouchScreen.tap #639
TouchScreen.tap #639
Conversation
lib/ElementHandle.js
Outdated
docs/api.md
Outdated
There was a problem hiding this comment.
can we explain what's a tap?
There was a problem hiding this comment.
A concise and effective definition: https://api.jquerymobile.com/tap
docs/api.md
Outdated
There was a problem hiding this comment.
can we also have page.tap() similarly to page.click()?
docs/api.md
Outdated
There was a problem hiding this comment.
the page.touchScreen feels slightly weird. Paul, any naming ideas? @paulirish
There was a problem hiding this comment.
we can do page.touchscreen, all lowercase because apparently touchscreen is one word
test/assets/input/touches.html
Outdated
There was a problem hiding this comment.
don't we have the same asset for mouse? Can we unify the two, simply recording all the events for the button?
There was a problem hiding this comment.
There is a similar one for keyboard, but it has a textarea.
test/test.js
Outdated
There was a problem hiding this comment.
is is actually ok to send touches to the non-touch viewport?
There was a problem hiding this comment.
It seems fine.
9dc6510 to
e3fbbbe
Compare
| await page.goto(PREFIX + '/input/touches.html'); | ||
| const button = await page.$('button'); | ||
| await button.tap(); | ||
| expect(await page.evaluate(() => getResult())).toEqual(['Touchstart: 0', 'Touchend: 0']); |
There was a problem hiding this comment.
Out of curiosity, how's getResult() different from result? You use one in the first test and other in the second
There was a problem hiding this comment.
it clears the result
|
I am waiting for swipe function，It may only be used now |
|
@JoelEinbinder thanks for your payout, how about the swipe, pinch and zoom events? when are they will be released? |
|
@JoelEinbinder Is swipe ready yet? |
it looks like no yet!! |
This adds a touchScreen input object with a
tapmethod, and an equivalenttapon elementHandle. In the future touchScreen with have methods likeswipe,pinchandzoom. The other methods are waiting on some backend work to make them less racy.#568 #569 #158