Skip to content

support npm proxy configuration for the installation script #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2017
Merged

support npm proxy configuration for the installation script #692

merged 2 commits into from
Sep 9, 2017

Conversation

@aslushnikov
Copy link
Contributor

@aslushnikov aslushnikov commented Sep 5, 2017

Fixes #648

@aslushnikov
Copy link
Contributor Author

aslushnikov commented Sep 5, 2017

For the future reference: this is done similarly to the phantomjs-prebuilt: https://github.com/Medium/phantomjs/blob/a98231b3f689607eb12da565179696476a839534/install.js#L154

@aslushnikov aslushnikov merged commit b8bb80a into puppeteer:master Sep 9, 2017
@aslushnikov aslushnikov deleted the npm-proxy-config branch October 10, 2017 00:20
@tomasAlabes tomasAlabes mentioned this pull request Nov 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aslushnikov @JoelEinbinder