Launcher: Close gracefully when a userDataDir is specified #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelEinbinder
commented
Sep 6, 2017
lib/Launcher.js
Outdated
There was a problem hiding this comment.
@aslushnikov I copied this from your previous PR. I'm not sure if we need it.
There was a problem hiding this comment.
That's to handle "process.exit " case.
aslushnikov
reviewed
Sep 6, 2017
test/test.js
Outdated
There was a problem hiding this comment.
let's make browser.close() return a promise
lib/Browser.js
Outdated
|
@JoelEinbinder any updates on this? |
eca4e8e to
2ff0bec
Compare
|
@aslushnikov I removed the event, |
aslushnikov
approved these changes
Sep 14, 2017
166af0a to
6c340ef
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My version of #693
In order to make tests work, I needed to add a
'close'event toBrowser. This broke the doclint, which didn't like browser having a'close'event and a.closemethod. So that is why this patch is bigger than it should be.Fixes #527