Implement page.authenticate method #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works great - even worked for NTLM |
dgozman
reviewed
Sep 11, 2017
lib/NetworkManager.js
Outdated
There was a problem hiding this comment.
Let's move this to _onRequestIntercepted.
dgozman
approved these changes
Sep 11, 2017
This patch implements `page.authenticate` which should cover all cases of HTTP authentication. Fixes puppeteer#426.
|
@aslushnikov Proxy authentication -> Request interception -> Cache disabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements
page.authenticatewhich should cover allcases of HTTP authentication.
Implementation notes:
of NetworkManager splits the "requestInterceptionEnabled" flag into two:
userRequestInterceptionEnabled-trueif the user has enabled request interceptionprotocolRequestInterceptionEnabled-trueif we've enabled request interception in protocolattemptedAuthenticationsset that stores all the interception ids we've tried to authenticate.Fixes #426.