Skip to content

Fix evaluation in case of first "undefind" argument #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2017
Merged

Fix evaluation in case of first "undefind" argument #732

merged 2 commits into from
Sep 11, 2017

Conversation

@aslushnikov
Copy link
Contributor

@aslushnikov aslushnikov commented Sep 9, 2017 •
edited
Loading

It turns out that [undefined, 1].join(',') results in ",1" instead
of "undefined,1". This causes a syntax error when trying to pass undefined
as a first argument to page.evaluate method.

Fixes #572.

@aslushnikov
Fix evaluation in case of first "undefind" argument
510ecba 
It turns out that [undefined, 1].join(',') results in ",1" instead
of "undefined,1". This causes a syntax error when trying to pass undefined
as a first argument to `page.evaluate` method.

Fixes puppeteer#572.
@aslushnikov
better testcase
24ffe40
@aslushnikov aslushnikov merged commit a71f287 into puppeteer:master Sep 11, 2017
@aslushnikov aslushnikov deleted the fix-bad-evaluate branch September 11, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aslushnikov @JoelEinbinder