Skip to content

Proposal: adding RESOURCES.md for examples #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2017
Merged

Proposal: adding RESOURCES.md for examples #743

merged 2 commits into from
Sep 11, 2017

Conversation

@LasaleFamine
Copy link
Contributor

@LasaleFamine LasaleFamine commented Sep 11, 2017

As discussed on #329. This is my proposal.

@googlebot
Copy link

googlebot commented Sep 11, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@LasaleFamine
Copy link
Contributor Author

LasaleFamine commented Sep 11, 2017

I signed it!

@googlebot
Copy link

googlebot commented Sep 11, 2017

CLAs look good, thanks!

@aslushnikov aslushnikov requested a review from ebidel September 11, 2017 16:45
ebidel
ebidel suggested changes Sep 11, 2017
View reviewed changes
examples/RESOURCES.md Outdated
@@ -0,0 +1,11 @@
# Resources and examples

> Useful tools or projects as example of main Puppeteer features.
Copy link
Contributor

@ebidel ebidel Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Other useful tools and projects that use Puppeteer."

examples/RESOURCES.md Outdated
> Useful tools or projects as example of main Puppeteer features.

## Web scraping
- [Puppetron](https://github.com/cheeaun/puppetron) - Non-production (Headless Chrome Node API)-based rendering solution.
Copy link
Contributor

@ebidel ebidel Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo site that shows how to use Puppeteer and Headless Chrome to render pages. Inspired by https://github.com/GoogleChrome/rendertron.

examples/RESOURCES.md Outdated

## Web scraping
- [Puppetron](https://github.com/cheeaun/puppetron) - Non-production (Headless Chrome Node API)-based rendering solution.
- [Thal](https://github.com/emadehsan/thal) - Getting started with Puppeteer and Chrome Headless for Web Scraping.
Copy link
Contributor

@ebidel ebidel Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just link to the article:
https://medium.com/@e_mad_ehsan/getting-started-with-puppeteer-and-chrome-headless-for-web-scrapping-6bf5979dee3e

examples/RESOURCES.md Outdated
- [Thal](https://github.com/emadehsan/thal) - Getting started with Puppeteer and Chrome Headless for Web Scraping.

## Testing
- [angular-puppeteer-demo](https://github.com/Quramy/angular-puppeteer-demo) - A demonstration repository explains how to replace from Karma to Puppeteer.
Copy link
Contributor

@ebidel ebidel Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo repository explaining how to use Puppeteer in Karma.

@LasaleFamine
Copy link
Contributor Author

LasaleFamine commented Sep 11, 2017

Changes made. Let me know if you need other changes. @ebidel

@ebidel ebidel merged commit 568b7bd into puppeteer:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ebidel ebidel ebidel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LasaleFamine @googlebot @ebidel