add Puppeteer.executablePath() method #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds Puppeteer.executablePath() method to query the path of bundled chromium. Fixes puppeteer#745
ebidel
reviewed
Sep 13, 2017
docs/api.md
Outdated
| This methods attaches Puppeteer to an existing Chromium instance. | ||
|
|
||
| #### puppeteer.executablePath() | ||
| - returns: <[string]> A path where Puppeteer expects to find bundled chromium. Chromium might not exist there if the download was skipped with `PUPPETEER_SKIP_CHROMIUM_DOWNLOAD`. |
There was a problem hiding this comment.
link to the env vars section
|
|
||
| This methods attaches Puppeteer to an existing Chromium instance. | ||
|
|
||
| #### puppeteer.executablePath() |
There was a problem hiding this comment.
This header is missing in the TOC.
JoelEinbinder
approved these changes
Sep 13, 2017
|
I added an alternative solution for #745 |
|
@Janpot the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds Puppeteer.executablePath() method to query the path
of bundled chromium.
Fixes #745