Launcher: disable extensions and google translate by default #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
approved these changes
Sep 14, 2017
|
@ebidel it turned out I don't really know why we want this in. Why would we want this? |
|
Keep the launched chrome slimmer? Not sure it adds a ton of value for us. Turning these off makes more sense for Lighthouse where we're reusing an existing install of chrome. |
|
I slept with this and now I like the patch since it aligns headful/headless with each other. |
JoelEinbinder
approved these changes
Sep 14, 2017
|
@aslushnikov , @JoelEinbinder, et al - Sadly creating and merging this has disabled everyone's ability to automate with extensions in non-headless mode. Is there any way to work around this, or are these "default" args more like "permanent unchangeable" args? |
|
@cretz @JoelEinbinder is working on a patch to override default arguments. Filed #872 to track progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches
puppeteer.launchto run chromium with disabledchrome extensions and google translate services.
References #760