Add keyboard methods to elementHandle #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Sep 16, 2017
docs/api.md
Outdated
There was a problem hiding this comment.
let's make selector unconditional here and in page.press. This would align better with the rest of the API. Having selector optional here might create false expectations from other API methods.
We'll break all the beta users, but that's why we're unstable yet.
There was a problem hiding this comment.
How do you feel above removing page.press
There was a problem hiding this comment.
How do you feel above removing page.press
@JoelEinbinder i like it.
lib/ElementHandle.js
Outdated
There was a problem hiding this comment.
nit: let's plumb page as a first entry here.
a5fefb6 to
1d0caa5
Compare
aslushnikov
approved these changes
Oct 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
elementHandle.focus,elementHandle.pressandelementHandle.type. It adds an optional selector argument topage.pressandpage.typeto align them withpage.click, and addskeyboard.pressandkeyboard.type.Closes #241