feat(Console): Introduce ConsoleMessage type #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/Page.js
Outdated
| } | ||
| const values = await Promise.all(event.args.map(arg => helper.serializeRemoteObject(this._client, arg))); | ||
| this.emit(Page.Events.Console, ...values); | ||
| const text = values.length && typeof values[0] === 'string' ? values[0] : null; |
There was a problem hiding this comment.
Let's make text all the values.join(" ")
|
|
||
| Dialog's type, could be one of the `alert`, `beforeunload`, `confirm` and `prompt`. | ||
|
|
||
| ### class: ConsoleMessage |
There was a problem hiding this comment.
Inline this into the console event?
There was a problem hiding this comment.
I think it's fine like this
JoelEinbinder
approved these changes
Sep 29, 2017
|
It seems these fragments also need updating: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces ConsoleMessage type and starts dispatching
it for the
'console'event.BREAKING CHANGE: this breaks the api of the
'console'event.Fixes #744.